Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: Source/bindings/tests/results/core/V8TestInterface.cpp

Issue 611953003: Canvas2D Performance: fix the bottleneck of hasInstance during JS binding -- overloading (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add code change in Source/bindings/tests/results/ Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestInterface.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterface.cpp b/Source/bindings/tests/results/core/V8TestInterface.cpp
index 3161e21693399bef41e9775485ff8d1b38cd7f31..73ed1af9bfeb95233f1e38736b405f470b8ebb92 100644
--- a/Source/bindings/tests/results/core/V8TestInterface.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterface.cpp
@@ -72,7 +72,7 @@ static void testInterfaceAttributeAttributeSetter(v8::Local<v8::Value> v8Value,
return;
}
TestInterfaceImplementation* impl = V8TestInterface::toImpl(holder);
- TestInterfaceImplementation* cppValue = V8TestInterface::toImplWithTypeCheck(info.GetIsolate(), v8Value);
+ TestInterfaceImplementation* cppValue = V8TestInterface::toImpl(v8::Handle<v8::Object>::Cast(v8Value));
impl->setTestInterfaceAttribute(WTF::getPtr(cppValue));
}
@@ -432,7 +432,7 @@ static void implementsNodeAttributeAttributeSetter(v8::Local<v8::Value> v8Value,
return;
}
TestInterfaceImplementation* impl = V8TestInterface::toImpl(holder);
- Node* cppValue = V8Node::toImplWithTypeCheck(info.GetIsolate(), v8Value);
+ Node* cppValue = V8Node::toImpl(v8::Handle<v8::Object>::Cast(v8Value));
impl->setImplementsNodeAttribute(WTF::getPtr(cppValue));
}
@@ -497,7 +497,7 @@ static void implementsRuntimeEnabledNodeAttributeAttributeSetter(v8::Local<v8::V
return;
}
TestInterfaceImplementation* impl = V8TestInterface::toImpl(holder);
- Node* cppValue = V8Node::toImplWithTypeCheck(info.GetIsolate(), v8Value);
+ Node* cppValue = V8Node::toImpl(v8::Handle<v8::Object>::Cast(v8Value));
impl->setImplementsRuntimeEnabledNodeAttribute(WTF::getPtr(cppValue));
}
@@ -532,7 +532,7 @@ static void implementsPerContextEnabledNodeAttributeAttributeSetter(v8::Local<v8
return;
}
TestInterfaceImplementation* impl = V8TestInterface::toImpl(holder);
- Node* cppValue = V8Node::toImplWithTypeCheck(info.GetIsolate(), v8Value);
+ Node* cppValue = V8Node::toImpl(v8::Handle<v8::Object>::Cast(v8Value));
impl->setImplementsPerContextEnabledNodeAttribute(WTF::getPtr(cppValue));
}
@@ -989,7 +989,7 @@ static void voidMethodTestInterfaceEmptyArgMethod(const v8::FunctionCallbackInfo
V8ThrowException::throwTypeError(ExceptionMessages::failedToExecute("voidMethodTestInterfaceEmptyArg", "TestInterface", "parameter 1 is not of type 'TestInterfaceEmpty'."), info.GetIsolate());
return;
}
- testInterfaceEmptyArg = V8TestInterfaceEmpty::toImplWithTypeCheck(info.GetIsolate(), info[0]);
+ testInterfaceEmptyArg = V8TestInterfaceEmpty::toImpl(v8::Handle<v8::Object>::Cast(info[0]));
}
impl->voidMethodTestInterfaceEmptyArg(testInterfaceEmptyArg);
}
@@ -1231,7 +1231,7 @@ static void implementsComplexMethodMethod(const v8::FunctionCallbackInfo<v8::Val
exceptionState.throwIfNeeded();
return;
}
- testInterfaceEmptyArg = V8TestInterfaceEmpty::toImplWithTypeCheck(info.GetIsolate(), info[1]);
+ testInterfaceEmptyArg = V8TestInterfaceEmpty::toImpl(v8::Handle<v8::Object>::Cast(info[1]));
}
ExecutionContext* executionContext = currentExecutionContext(info.GetIsolate());
RefPtr<TestInterfaceEmpty> result = impl->implementsComplexMethod(executionContext, strArg, testInterfaceEmptyArg, exceptionState);

Powered by Google App Engine
This is Rietveld 408576698