Source/bindings/scripts/v8_types.py - Issue 611953003: Canvas2D Performance: fix the bottleneck of hasInstance during JS binding -- overloading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 611953003: Canvas2D Performance: fix the bottleneck of hasInstance during JS binding -- overloading (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add code change in Source/bindings/tests/results/ Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_types.py

diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py

index a63a39326c34290d437e66f575a8979d8e177ec1..e214a39257edacc98fa3a95d5677fb8b0a863ada 100644

--- a/Source/bindings/scripts/v8_types.py

+++ b/Source/bindings/scripts/v8_types.py

@@ -534,7 +534,7 @@ def v8_value_to_cpp_value(idl_type, extended_attributes, v8_value, index, isolat

cpp_expression_format = 'V8{idl_type}::toImpl({isolate}, {v8_value}, exceptionState)'

else:

cpp_expression_format = (

- 'V8{idl_type}::toImplWithTypeCheck({isolate}, {v8_value})')

+ 'V8{idl_type}::toImpl(v8::Handle<v8::Object>::Cast({v8_value}))')

return cpp_expression_format.format(arguments=arguments, idl_type=base_idl_type, v8_value=v8_value, isolate=isolate)

« Source/bindings/scripts/v8_interface.py ('K') | « Source/bindings/scripts/v8_methods.py ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »