Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1581)

Unified Diff: ui/file_manager/video_player/js/media_controls.js

Issue 611953002: Video Player: Don't show the loop message in unexpected timing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/file_manager/video_player/css/media_controls.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/video_player/js/media_controls.js
diff --git a/ui/file_manager/video_player/js/media_controls.js b/ui/file_manager/video_player/js/media_controls.js
index 8d63495b2e60d3e47deef5da9cfb806d94d8ee51..35c9f6317ab514387aa4582c4a79f8ad1c623b84 100644
--- a/ui/file_manager/video_player/js/media_controls.js
+++ b/ui/file_manager/video_player/js/media_controls.js
@@ -1026,9 +1026,19 @@ VideoControls.prototype.showIconFeedback_ = function() {
* @private
*/
VideoControls.prototype.showTextBanner_ = function(identifier) {
+ var text = this.stringFunction_(identifier);
+
this.textBanner_.removeAttribute('visible');
- this.textBanner_.textContent = this.stringFunction_(identifier);
+ this.textBanner_.textContent = text;
+
setTimeout(function() {
+ var onAnimationEnd = function(text, event) {
fukino 2014/09/29 08:04:29 This 'text' looks unused. Can we get rid of it?
yoshiki 2014/09/29 08:10:19 Done.
+ this.textBanner_.removeEventListener(
+ 'webkitAnimationEnd', onAnimationEnd);
+ this.textBanner_.removeAttribute('visible');
+ }.bind(this, text);
+ this.textBanner_.addEventListener('webkitAnimationEnd', onAnimationEnd);
+
this.textBanner_.setAttribute('visible', 'true');
}.bind(this), 0);
};
« no previous file with comments | « ui/file_manager/video_player/css/media_controls.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698