Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 611953002: Video Player: Don't show the loop message in unexpected timing (Closed)

Created:
6 years, 2 months ago by yoshiki
Modified:
6 years, 2 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Video Player: Don't show the loop message in unexpected timing BUG=418275 TEST=manually tested Committed: https://crrev.com/b885fc3b198e7d8772d1e8c4e4f93d470eb65ae1 Cr-Commit-Position: refs/heads/master@{#297151}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed the fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ui/file_manager/video_player/css/media_controls.css View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/file_manager/video_player/js/media_controls.js View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
yoshiki
@fukino-san, PTAL. Thanks.
6 years, 2 months ago (2014-09-29 07:57:09 UTC) #2
fukino
https://codereview.chromium.org/611953002/diff/1/ui/file_manager/video_player/js/media_controls.js File ui/file_manager/video_player/js/media_controls.js (right): https://codereview.chromium.org/611953002/diff/1/ui/file_manager/video_player/js/media_controls.js#newcode1035 ui/file_manager/video_player/js/media_controls.js:1035: var onAnimationEnd = function(text, event) { This 'text' looks ...
6 years, 2 months ago (2014-09-29 08:04:29 UTC) #3
yoshiki
@fukino, PTAL https://codereview.chromium.org/611953002/diff/1/ui/file_manager/video_player/js/media_controls.js File ui/file_manager/video_player/js/media_controls.js (right): https://codereview.chromium.org/611953002/diff/1/ui/file_manager/video_player/js/media_controls.js#newcode1035 ui/file_manager/video_player/js/media_controls.js:1035: var onAnimationEnd = function(text, event) { On ...
6 years, 2 months ago (2014-09-29 08:10:19 UTC) #4
fukino
On 2014/09/29 08:10:19, yoshiki wrote: > @fukino, PTAL > > https://codereview.chromium.org/611953002/diff/1/ui/file_manager/video_player/js/media_controls.js > File ui/file_manager/video_player/js/media_controls.js (right): ...
6 years, 2 months ago (2014-09-29 08:10:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611953002/20001
6 years, 2 months ago (2014-09-29 08:12:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as eeee6758718c07a716d622dcbe55959c04be1cb1
6 years, 2 months ago (2014-09-29 08:50:21 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 08:51:06 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b885fc3b198e7d8772d1e8c4e4f93d470eb65ae1
Cr-Commit-Position: refs/heads/master@{#297151}

Powered by Google App Engine
This is Rietveld 408576698