Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 611923002: [WebBlobRegistry] Use char* than WebThreadSafeData (Closed)

Created:
6 years, 2 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 2 months ago
Reviewers:
tkent, yhirano
CC:
blink-reviews, jamesr, dglazkov+blink, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[WebBlobRegistry] Use char* than WebThreadSafeData We don't need to wrap the data with WebThreadSafeData here. Just use a pair of const char* and size_t. This is Blink side CL. Chromium side CL: https://codereview.chromium.org/610333002/ R=yhirano,tkent BUG=417093 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184141

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M Source/platform/blob/BlobRegistry.cpp View 1 2 chunks +4 lines, -7 lines 0 comments Download
M public/platform/WebBlobRegistry.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
tyoshino (SeeGerritForStatus)
6 years, 2 months ago (2014-09-29 06:22:13 UTC) #3
tyoshino (SeeGerritForStatus)
I haven't tested if this resolves bug417093 or not. Even if it doesn't, this clean ...
6 years, 2 months ago (2014-09-29 06:28:49 UTC) #4
yhirano
lgtm
6 years, 2 months ago (2014-09-29 08:54:14 UTC) #5
tyoshino (SeeGerritForStatus)
+tkent
6 years, 2 months ago (2014-09-29 08:55:36 UTC) #7
tyoshino (SeeGerritForStatus)
This CL depends on Chromium side CL: https://codereview.chromium.org/610333002/
6 years, 2 months ago (2014-09-29 08:56:13 UTC) #8
tkent
lgtm
6 years, 2 months ago (2014-09-30 01:26:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611923002/20001
6 years, 2 months ago (2014-10-22 03:25:49 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 04:25:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184141

Powered by Google App Engine
This is Rietveld 408576698