Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 611833005: Force creation of application listening socket (Closed)

Created:
6 years, 2 months ago by Chris Masone
Modified:
6 years, 2 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@flag
Project:
chromium
Visibility:
Public.

Description

Force creation of application listening socket If a previous mojo_shell run exited uncleanly, there may be a unix domain socket sitting at the path that IncomingConnectionListener wants to own and listen at. This change destroys it, if possible, and creates a new one. BUG=407782 TEST=new unit test, run mojo_shell multiple times in a row with --enable-external-applications Committed: https://crrev.com/5e0ad88bc5646fee917b0ff09283eaeb494b6ece Cr-Commit-Position: refs/heads/master@{#297271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M mojo/shell/incoming_connection_listener_posix.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/shell/incoming_connection_listener_unittest.cc View 1 chunk +26 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Chris Masone
PTAL
6 years, 2 months ago (2014-09-29 20:17:11 UTC) #1
Chris Masone
PTAL. I guess that git cl owners thing doesn't work like I think it does...
6 years, 2 months ago (2014-09-29 20:17:42 UTC) #3
DaveMoore
lgtm
6 years, 2 months ago (2014-09-29 20:19:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611833005/1
6 years, 2 months ago (2014-09-29 20:27:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as dce5f056991043606e3330452f2c24aea67becc9
6 years, 2 months ago (2014-09-29 21:21:36 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 21:25:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e0ad88bc5646fee917b0ff09283eaeb494b6ece
Cr-Commit-Position: refs/heads/master@{#297271}

Powered by Google App Engine
This is Rietveld 408576698