Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 611773002: Fixing issues with new activity image readback (Closed)

Created:
6 years, 2 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 2 months ago
Reviewers:
sadrul
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixing issues with new activity image readback While writing the unit tests I have found problems and fixed them. Since I am not sure when the unit tests will land however (they come with the new Athena Browser test framework) I created this patch to get a workable version for Sadrul's Overview mode work. BUG=408837 TEST=tests are in different CL which introduces Browser Tests for Athena Committed: https://crrev.com/b5524e546f366cb73f7f50651919623bb5f0913e Cr-Commit-Position: refs/heads/master@{#297193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M athena/content/content_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/content/web_activity.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mr4D (OOO till 08-26)
Please have a look! I hope this helps with your overview mode changes. Please note ...
6 years, 2 months ago (2014-09-27 16:29:22 UTC) #2
sadrul
lgtm
6 years, 2 months ago (2014-09-29 15:55:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611773002/1
6 years, 2 months ago (2014-09-29 16:12:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 73c1ee8c9eb4a35bd6fad0884f4dabc7b36f0ba7
6 years, 2 months ago (2014-09-29 16:51:58 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 16:52:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5524e546f366cb73f7f50651919623bb5f0913e
Cr-Commit-Position: refs/heads/master@{#297193}

Powered by Google App Engine
This is Rietveld 408576698