Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 611733002: Mojo: Convert OVERRIDE -> override in mojo/{embedder,system}. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Convert OVERRIDE -> override in mojo/{embedder,system}. R=jamesr@chromium.org Committed: https://crrev.com/b7776df077b144bbf34250fc879246f25fd251de Cr-Commit-Position: refs/heads/master@{#297119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -157 lines) Patch
M mojo/embedder/simple_platform_shared_buffer.h View 2 chunks +8 lines, -8 lines 0 comments Download
M mojo/embedder/simple_platform_support.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/system/channel.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/system/channel_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M mojo/system/core_test_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/system/core_test_base.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M mojo/system/data_pipe_consumer_dispatcher.h View 1 chunk +11 lines, -11 lines 0 comments Download
M mojo/system/data_pipe_producer_dispatcher.h View 1 chunk +11 lines, -11 lines 0 comments Download
M mojo/system/dispatcher_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/system/local_data_pipe.h View 1 chunk +12 lines, -12 lines 0 comments Download
M mojo/system/local_message_pipe_endpoint.h View 1 chunk +9 lines, -9 lines 0 comments Download
M mojo/system/message_pipe_dispatcher.h View 2 chunks +11 lines, -11 lines 0 comments Download
M mojo/system/message_pipe_dispatcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/platform_handle_dispatcher.h View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/system/raw_channel_posix.cc View 1 chunk +12 lines, -12 lines 0 comments Download
M mojo/system/raw_channel_unittest.cc View 11 chunks +14 lines, -14 lines 0 comments Download
M mojo/system/raw_channel_win.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M mojo/system/remote_message_pipe_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/system/shared_buffer_dispatcher.h View 2 chunks +7 lines, -7 lines 0 comments Download
M mojo/system/simple_dispatcher.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/system/simple_dispatcher_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/system/waiter_test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/waiter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 2 months ago (2014-09-27 01:26:46 UTC) #1
jamesr
lgtm
6 years, 2 months ago (2014-09-27 20:33:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611733002/1
6 years, 2 months ago (2014-09-27 20:34:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as d21fb9e2bc86679dbec04127f65eff550536b191
6 years, 2 months ago (2014-09-27 21:31:52 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-27 21:32:34 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b7776df077b144bbf34250fc879246f25fd251de
Cr-Commit-Position: refs/heads/master@{#297119}

Powered by Google App Engine
This is Rietveld 408576698