Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 611693002: Printing: Take the PDF rotation into account when printing on Mac. (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Printing: Take the PDF rotation into account when printing on Mac. Derived from worksheet attached to https://code.google.com/p/chromium/issues/detail?id=369206#c17 BUG=369206 TEST=Manual, see bug. Committed: https://crrev.com/23fe517793b2c801eaab2871a6aedaab230acda6 Cr-Commit-Position: refs/heads/master@{#297114}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -5 lines) Patch
M printing/pdf_metafile_cg_mac.cc View 3 chunks +47 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Lei Zhang
PDF rotations are fun!</sarcasm>
6 years, 2 months ago (2014-09-26 22:17:02 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 2 months ago (2014-09-27 16:46:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611693002/1
6 years, 2 months ago (2014-09-27 16:52:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as b3cc75dcb6002674e5f99c436cf7e9827184016a
6 years, 2 months ago (2014-09-27 17:41:01 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-27 17:41:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23fe517793b2c801eaab2871a6aedaab230acda6
Cr-Commit-Position: refs/heads/master@{#297114}

Powered by Google App Engine
This is Rietveld 408576698