Cleanup of shader building system

src/gpu/gl/GrGLProgramDataManager.h

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef GrGLProgramDataManager_DEFINED
 #define GrGLProgramDataManager_DEFINED
 
@@ skipping 36 matching lines @@
         static UniformHandle CreateFromUniformIndex(int i);
         UniformHandle() { }
         bool operator==(const UniformHandle& other) const { return other.fValue == fValue; }
     private:
         UniformHandle(int value) : ShaderResourceHandle(value) { }
         int toProgramDataIndex() const { SkASSERT(isValid()); return fValue; }
         int toShaderBuilderIndex() const { return toProgramDataIndex(); }
 
         friend class GrGLProgramDataManager; // For accessing toProgramDataIndex().
         friend class GrGLProgramBuilder; // For accessing toShaderBuilderIndex().
+        friend class GrGLSkiaProgramBuilder; // for accessing toShaderBuilderIndex;
     };
 
-    class VaryingHandle : public ShaderResourceHandle {
-    public:
-        /** Creates a reference to a varying in separable varyings of a GrGLShaderBuilder.
-         * The ref can be used to set the varying with the corresponding GrGLProgramDataManager.*/
-        static VaryingHandle CreateFromSeparableVaryingIndex(int i) {
-            return VaryingHandle(i);
-        }
-        VaryingHandle() { }
-        bool operator==(const VaryingHandle& other) const { return other.fValue == fValue; }
-    private:
-        VaryingHandle(int value) : ShaderResourceHandle(value) { }
-        int toProgramDataIndex() const { SkASSERT(isValid()); return fValue; }
-        friend class GrGLProgramDataManager; // For accessing toProgramDataIndex().
+    struct UniformInfo {
+        GrGLShaderVar fVariable;
+        uint32_t      fVisibility;
+        GrGLint       fLocation;
     };
 
-    GrGLProgramDataManager(GrGpuGL*, GrGLProgram*, const GrGLProgramBuilder&);
+    // This uses an allocator rather than array so that the GrGLShaderVars don't move in memory
+    // after they are inserted. Users of GrGLShaderBuilder get refs to the vars and ptrs to their
+    // name strings. Otherwise, we'd have to hand out copies.
+    typedef GrTAllocator<UniformInfo> UniformInfoArray;
+
+    GrGLProgramDataManager(GrGpuGL*, const UniformInfoArray&);
 
     /** Functions for uploading uniform values. The varities ending in v can be used to upload to an
      *  array of uniforms. arrayCount must be <= the array count of the uniform.
      */
     void setSampler(UniformHandle, GrGLint texUnit) const;
     void set1f(UniformHandle, GrGLfloat v0) const;
     void set1fv(UniformHandle, int arrayCount, const GrGLfloat v[]) const;
     void set2f(UniformHandle, GrGLfloat, GrGLfloat) const;
     void set2fv(UniformHandle, int arrayCount, const GrGLfloat v[]) const;
     void set3f(UniformHandle, GrGLfloat, GrGLfloat, GrGLfloat) const;
     void set3fv(UniformHandle, int arrayCount, const GrGLfloat v[]) const;
     void set4f(UniformHandle, GrGLfloat, GrGLfloat, GrGLfloat, GrGLfloat) const;
     void set4fv(UniformHandle, int arrayCount, const GrGLfloat v[]) const;
     // matrices are column-major, the first three upload a single matrix, the latter three upload
     // arrayCount matrices into a uniform array.
     void setMatrix3f(UniformHandle, const GrGLfloat matrix[]) const;
     void setMatrix4f(UniformHandle, const GrGLfloat matrix[]) const;
     void setMatrix3fv(UniformHandle, int arrayCount, const GrGLfloat matrices[]) const;
     void setMatrix4fv(UniformHandle, int arrayCount, const GrGLfloat matrices[]) const;
 
     // convenience method for uploading a SkMatrix to a 3x3 matrix uniform
     void setSkMatrix(UniformHandle, const SkMatrix&) const;
 
-    void setProgramPathFragmentInputTransform(VaryingHandle i,
-                                              unsigned components,
-                                              const SkMatrix& matrix) const;
-
 private:
     enum {
         kUnusedUniform = -1,
     };
 
     struct Uniform {
         GrGLint     fVSLocation;
         GrGLint     fFSLocation;
         SkDEBUGCODE(
             GrSLType    fType;
             int         fArrayCount;
         );
     };
-    struct Varying {
-        GrGLint     fLocation;
-        SkDEBUGCODE(
-            GrSLType    fType;
-        );
-    };
 
     SkTArray<Uniform, true> fUniforms;
-    SkTArray<Varying, true> fVaryings;
     GrGpuGL* fGpu;
-    GrGLProgram* fProgram;
 
     typedef SkRefCnt INHERITED;
 };
-
 #endif