Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 61163002: Remove render_process_host_factory_ from SiteInstanceImpl. (Closed)

Created:
7 years, 1 month ago by ncarter (slow)
Modified:
7 years, 1 month ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org, ajwong+watch_chromium.org
Visibility:
Public.

Description

Remove render_process_host_factory_ from SiteInstanceImpl. This member has been unused and uninitialized since r204409, but it looks like we forgot to actually remove the member. BUG=NONE TEST=trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233536

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/browser/site_instance_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ncarter (slow)
7 years, 1 month ago (2013-11-05 22:27:35 UTC) #1
Charlie Reis
Good catch! Always happy to remove dead code. LGTM.
7 years, 1 month ago (2013-11-05 22:30:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nick@chromium.org/61163002/1
7 years, 1 month ago (2013-11-05 22:43:51 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94348
7 years, 1 month ago (2013-11-06 03:41:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nick@chromium.org/61163002/1
7 years, 1 month ago (2013-11-06 19:01:05 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 07:53:37 UTC) #6
Message was sent while issue was closed.
Change committed as 233536

Powered by Google App Engine
This is Rietveld 408576698