Issue 611623002: Consolidate all banned features into one table.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 611623002: Consolidate all banned features into one table. (Closed)

Created:
6 years, 2 months ago by Avi (use Gerrit)

Modified:
6 years, 2 months ago

Reviewers:
jamesr, awong

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Consolidate all banned features into one table. This is a slight cleanup after d9a02e76127634286ff0c760f87db260b367492a. BUG= Committed: https://crrev.com/906dbd5c2580b79f4809cd5d5cd8cb40a21aa10d Cr-Commit-Position: refs/heads/master@{#297052}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -23 lines)			Patch
	M	styleguide/c++/c++11.html	View		3 chunks	+9 lines, -23 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jamesr

lgtm Seems fine, but I can't review html usefully in rietveld.

6 years, 2 months ago (2014-09-26 21:05:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611623002/1

6 years, 2 months ago (2014-09-26 21:18:32 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 698c1a3e971a83c2c8f55329087e423d634a161c

6 years, 2 months ago (2014-09-26 22:11:51 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-09-26 22:12:29 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/906dbd5c2580b79f4809cd5d5cd8cb40a21aa10d
Cr-Commit-Position: refs/heads/master@{#297052}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages