chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc - Issue 611603002: Add the goog-unwanted-shavar list to a new SafeBrowsing PrefixSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 611603002: Add the goog-unwanted-shavar list to a new SafeBrowsing PrefixSet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits and cl format Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page.cc ('k') | chrome/browser/safe_browsing/safe_browsing_database.h » ('j') | chrome/browser/safe_browsing/safe_browsing_database.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

index 07c02654993f98f8046d37af61a9587170a9e1ee..42d0d694d335cc9a087dd5bd18bd66daeaf780ae 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

@@ -634,7 +634,7 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingBlockingPageBrowserTest,

return;

#endif

- SetupWarningAndNavigate(SB_THREAT_TYPE_URL_HARMFUL);

+ SetupWarningAndNavigate(SB_THREAT_TYPE_URL_UNWANTED);

EXPECT_EQ(VISIBLE, GetVisibility("primary-button"));

EXPECT_EQ(HIDDEN, GetVisibility("details"));

@@ -661,7 +661,7 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingBlockingPageBrowserTest, MalwareProceed) {

}

IN_PROC_BROWSER_TEST_F(SafeBrowsingBlockingPageBrowserTest, HarmfulProceed) {

- GURL url = SetupWarningAndNavigate(SB_THREAT_TYPE_URL_HARMFUL);

+ GURL url = SetupWarningAndNavigate(SB_THREAT_TYPE_URL_UNWANTED);

EXPECT_TRUE(ClickAndWaitForDetach("proceed-link"));

AssertNoInterstitial(true); // Assert the interstitial is gone.