chrome/browser/safe_browsing/ping_manager.cc - Issue 611603002: Add the goog-unwanted-shavar list to a new SafeBrowsing PrefixSet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/ping_manager.cc

Issue 611603002: Add the goog-unwanted-shavar list to a new SafeBrowsing PrefixSet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits and cl format Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/database_manager_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page.cc » ('j') | chrome/browser/safe_browsing/safe_browsing_database.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/ping_manager.cc

diff --git a/chrome/browser/safe_browsing/ping_manager.cc b/chrome/browser/safe_browsing/ping_manager.cc

index 92b032921beee2c8b42d4c82cdc2abc11cde989a..04783410fcef1f848ef6e6dd4a0d51160d14c223 100644

--- a/chrome/browser/safe_browsing/ping_manager.cc

+++ b/chrome/browser/safe_browsing/ping_manager.cc

@@ -101,6 +101,7 @@ GURL SafeBrowsingPingManager::SafeBrowsingHitUrl(

SBThreatType threat_type) const {

DCHECK(threat_type == SB_THREAT_TYPE_URL_MALWARE ||

threat_type == SB_THREAT_TYPE_URL_PHISHING ||

+ threat_type == SB_THREAT_TYPE_URL_UNWANTED ||

threat_type == SB_THREAT_TYPE_BINARY_MALWARE_URL ||

threat_type == SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL ||

threat_type == SB_THREAT_TYPE_CLIENT_SIDE_MALWARE_URL);

@@ -114,6 +115,9 @@ GURL SafeBrowsingPingManager::SafeBrowsingHitUrl(

case SB_THREAT_TYPE_URL_PHISHING:

threat_list = "phishblhit";

break;

+ case SB_THREAT_TYPE_URL_UNWANTED:

+ threat_list = "uwsblhit";

+ break;

case SB_THREAT_TYPE_BINARY_MALWARE_URL:

threat_list = "binurlhit";

break;