Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chrome/browser/safe_browsing/database_manager.h

Issue 611603002: Add the goog-unwanted-shavar list to a new SafeBrowsing PrefixSet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits and cl format Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/database_manager.h
diff --git a/chrome/browser/safe_browsing/database_manager.h b/chrome/browser/safe_browsing/database_manager.h
index e001a35e0705516df9fa53fe56b52d0dfecbc81e..a3e011761e2f30b1999e0ab51e407885218c4e72 100644
--- a/chrome/browser/safe_browsing/database_manager.h
+++ b/chrome/browser/safe_browsing/database_manager.h
@@ -216,7 +216,8 @@ class SafeBrowsingDatabaseManager
friend class SafeBrowsingServiceTest;
friend class SafeBrowsingServiceTestHelper;
friend class SafeBrowsingDatabaseManagerTest;
- FRIEND_TEST_ALL_PREFIXES(SafeBrowsingDatabaseManagerTest, GetUrlThreatType);
+ FRIEND_TEST_ALL_PREFIXES(SafeBrowsingDatabaseManagerTest,
+ GetUrlSeverestThreatType);
typedef std::set<SafeBrowsingCheck*> CurrentChecks;
typedef std::vector<SafeBrowsingCheck*> GetHashRequestors;
@@ -237,16 +238,16 @@ class SafeBrowsingDatabaseManager
base::TimeTicks start; // When check was queued.
};
- // Return the threat type from the first result in |full_hashes| which matches
+ // Return the threat type of the severest entry in |full_hashes| which matches
// |hash|, or SAFE if none match.
- static SBThreatType GetHashThreatType(
+ static SBThreatType GetHashSeverestThreatType(
const SBFullHash& hash,
const std::vector<SBFullHashResult>& full_hashes);
// Given a URL, compare all the possible host + path full hashes to the set of
- // provided full hashes. Returns the threat type of the matching result from
- // |full_hashes|, or SAFE if none match.
- static SBThreatType GetUrlThreatType(
+ // provided full hashes. Returns the threat type of the severest matching
+ // result from |full_hashes|, or SAFE if none match.
+ static SBThreatType GetUrlSeverestThreatType(
const GURL& url,
const std::vector<SBFullHashResult>& full_hashes,
size_t* index);
@@ -389,6 +390,9 @@ class SafeBrowsingDatabaseManager
// Indicate if the csd malware IP blacklist should be enabled.
bool enable_ip_blacklist_;
+ // Indicate if the unwanted software blacklist should be enabled.
+ bool enable_unwanted_software_blacklist_;
+
// The SafeBrowsing thread that runs database operations.
//
// Note: Functions that run on this thread should run synchronously and return
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/database_manager.cc » ('j') | chrome/browser/safe_browsing/safe_browsing_database.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698