Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 611573002: Refresh Public Suffix List to the latest version (Closed)

Created:
6 years, 2 months ago by Ryan Sleevi
Modified:
6 years, 2 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refresh Public Suffix List to the latest version This updates to the following revision: f2c25ddbd1cf 2014-09-02 07:27 +0200 It includes changes from revision aedf1212d667 (2014-08-05 11:00 -0400) to revision f2c25ddbd1cf (2014-09-02 07:27 +0200), listed at http://hg.mozilla.org/mozilla-central/log/f2c25ddbd1cf/netwerk/dns/effective_tld_names.dat R=pkasting@chromium.org BUG=37436 Committed: https://crrev.com/97076f1a6859da1606914b8c0711b548435f3b3a Cr-Commit-Position: refs/heads/master@{#297042}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1131 lines, -957 lines) Patch
M net/base/registry_controlled_domains/effective_tld_names.dat View 11 chunks +1071 lines, -952 lines 1 comment Download
M net/base/registry_controlled_domains/effective_tld_names.gperf View 59 chunks +60 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Ryan Sleevi
peter: Please take a look
6 years, 2 months ago (2014-09-26 19:09:40 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/611573002/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat File net/base/registry_controlled_domains/effective_tld_names.dat (right): https://codereview.chromium.org/611573002/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat#newcode6043 net/base/registry_controlled_domains/effective_tld_names.dat:6043: // Used by Northern Cyprus It seems like ...
6 years, 2 months ago (2014-09-26 20:25:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611573002/1
6 years, 2 months ago (2014-09-26 20:27:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 58604ddb7ebd53fdf7af86423a5d08e82625dfef
6 years, 2 months ago (2014-09-26 21:41:52 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 21:42:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97076f1a6859da1606914b8c0711b548435f3b3a
Cr-Commit-Position: refs/heads/master@{#297042}

Powered by Google App Engine
This is Rietveld 408576698