Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6424)

Unified Diff: chrome/browser/resources/feedback/js/feedback.js

Issue 61153007: Reduce delay when showing feedback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/feedback/js/take_screenshot.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/feedback/js/feedback.js
diff --git a/chrome/browser/resources/feedback/js/feedback.js b/chrome/browser/resources/feedback/js/feedback.js
index f79e0946feac0b642745413f636545735721a872..9e39158dd40effa5c1020c75810ec900bc301934 100644
--- a/chrome/browser/resources/feedback/js/feedback.js
+++ b/chrome/browser/resources/feedback/js/feedback.js
@@ -235,13 +235,18 @@ function initialize() {
if (feedbackInfo.pageUrl)
$('page-url-text').value = feedbackInfo.pageUrl;
- takeScreenshot(function(screenshotDataUrl) {
- $('screenshot-image').src = screenshotDataUrl;
- feedbackInfo.screenshot = dataUrlToBlob(screenshotDataUrl);
+ takeScreenshot(function(screenshotCanvas) {
// TODO(rkc): Remove logging once crbug.com/284662 is closed.
console.log('FEEDBACK_DEBUG: Taken screenshot. Showing window.');
+
+ // We've taken our screenshot, show the feedback page without any
+ // further delay.
resizeAppWindow();
chrome.app.window.current().show();
+
+ var screenshotDataUrl = screenshotCanvas.toDataURL('image/png');
+ $('screenshot-image').src = screenshotDataUrl;
+ feedbackInfo.screenshot = dataUrlToBlob(screenshotDataUrl);
});
chrome.feedbackPrivate.getUserEmail(function(email) {
« no previous file with comments | « no previous file | chrome/browser/resources/feedback/js/take_screenshot.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698