Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 611523003: styleguide: Put RValue references in the right place. (Closed)

Created:
6 years, 2 months ago by danakj
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

styleguide: Put RValue references in the right place. They should be part of the group of banned stuff, not in their own category. R=jamesr@chromium.org

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixhtml: alpha #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -22 lines) Patch
M styleguide/c++/c++11.html View 1 2 chunks +8 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
danakj
6 years, 2 months ago (2014-09-26 21:02:09 UTC) #1
Avi (use Gerrit)
Everything in the file is in alphabetical order; you should preserve that. Alternatively, you can ...
6 years, 2 months ago (2014-09-26 21:03:58 UTC) #3
danakj
Did not notice that, sorted it.
6 years, 2 months ago (2014-09-26 21:04:43 UTC) #4
Avi (use Gerrit)
On 2014/09/26 21:04:43, danakj wrote: > Did not notice that, sorted it. James OKed my ...
6 years, 2 months ago (2014-09-26 21:17:07 UTC) #5
danakj
6 years, 2 months ago (2014-09-26 21:20:25 UTC) #6
Message was sent while issue was closed.
On 2014/09/26 21:17:07, Avi wrote:
> On 2014/09/26 21:04:43, danakj wrote:
> > Did not notice that, sorted it.
> 
> James OKed my version: https://codereview.chromium.org/611623002/ so I'm going
> to commit it.

Sounds good, thanks.

Powered by Google App Engine
This is Rietveld 408576698