Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 611523002: Histograms.xml: script streaming related update. (Closed)

Created:
6 years, 2 months ago by marja
Modified:
6 years, 2 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Histograms.xml: script streaming related update. R=isherman@chromium.org BUG= Committed: https://crrev.com/aa2d0cbad5097813dd44355a5e176a27dab8241c Cr-Commit-Position: refs/heads/master@{#297152}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M tools/metrics/histograms/histograms.xml View 3 chunks +20 lines, -6 lines 3 comments Download

Messages

Total messages: 9 (1 generated)
marja
isherman, ptal
6 years, 2 months ago (2014-09-26 15:15:24 UTC) #1
marja
(also feel free to put this to CQ if it lgty; timezones...)
6 years, 2 months ago (2014-09-26 15:18:08 UTC) #2
Ilya Sherman
LGTM % a request: https://codereview.chromium.org/611523002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/611523002/diff/1/tools/metrics/histograms/histograms.xml#oldcode37258 tools/metrics/histograms/histograms.xml:37258: - units="milliseconds"> Please mark this ...
6 years, 2 months ago (2014-09-26 17:32:38 UTC) #3
marja
https://codereview.chromium.org/611523002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/611523002/diff/1/tools/metrics/histograms/histograms.xml#oldcode37258 tools/metrics/histograms/histograms.xml:37258: - units="milliseconds"> On 2014/09/26 17:32:38, Ilya Sherman wrote: > ...
6 years, 2 months ago (2014-09-26 20:42:21 UTC) #4
Ilya Sherman
https://codereview.chromium.org/611523002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/611523002/diff/1/tools/metrics/histograms/histograms.xml#oldcode37258 tools/metrics/histograms/histograms.xml:37258: - units="milliseconds"> On 2014/09/26 20:42:21, marja wrote: > On ...
6 years, 2 months ago (2014-09-26 20:59:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611523002/1
6 years, 2 months ago (2014-09-29 08:09:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7ef70d70ecfa546e0f2837281a6c11b98631e786
6 years, 2 months ago (2014-09-29 09:06:51 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 09:08:06 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa2d0cbad5097813dd44355a5e176a27dab8241c
Cr-Commit-Position: refs/heads/master@{#297152}

Powered by Google App Engine
This is Rietveld 408576698