Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 611513005: Pass initDataType instead of contentType on OnNeedKey(). (Closed)

Created:
6 years, 2 months ago by sandersd (OOO until July 31)
Modified:
6 years, 2 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, eme-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Pass initDataType instead of contentType to OnNeedKey(). BUG=224786 Committed: https://crrev.com/2983dc91cc0bc7be6014f4bfc5cb19cc6e262a0b Cr-Commit-Position: refs/heads/master@{#297523}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Fixes. #

Patch Set 3 : Fix pipeline integration test. #

Patch Set 4 : Again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -32 lines) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/crypto/encrypted_media_player_support_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/crypto/proxy_decryptor.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/crypto/proxy_decryptor.cc View 1 2 chunks +1 line, -12 lines 0 comments Download
M media/filters/pipeline_integration_test.cc View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser_unittest.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M media/formats/webm/webm_crypto_helpers.h View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 23 (8 generated)
sandersd (OOO until July 31)
6 years, 2 months ago (2014-09-26 21:38:03 UTC) #2
ddorwin
https://codereview.chromium.org/611513005/diff/1/content/renderer/media/crypto/encrypted_media_player_support_impl.cc File content/renderer/media/crypto/encrypted_media_player_support_impl.cc (right): https://codereview.chromium.org/611513005/diff/1/content/renderer/media/crypto/encrypted_media_player_support_impl.cc#newcode118 content/renderer/media/crypto/encrypted_media_player_support_impl.cc:118: static std::string GuessInitDataType(const unsigned char* init_data, Fix WMPA too. ...
6 years, 2 months ago (2014-09-26 22:09:18 UTC) #3
sandersd (OOO until July 31)
https://codereview.chromium.org/611513005/diff/1/content/renderer/media/crypto/encrypted_media_player_support_impl.cc File content/renderer/media/crypto/encrypted_media_player_support_impl.cc (right): https://codereview.chromium.org/611513005/diff/1/content/renderer/media/crypto/encrypted_media_player_support_impl.cc#newcode118 content/renderer/media/crypto/encrypted_media_player_support_impl.cc:118: static std::string GuessInitDataType(const unsigned char* init_data, On 2014/09/26 22:09:18, ...
6 years, 2 months ago (2014-09-26 22:49:56 UTC) #4
ddorwin
lgtm Thanks.
6 years, 2 months ago (2014-09-26 22:53:20 UTC) #5
ddorwin
I think you need to update some tests before committing, though.
6 years, 2 months ago (2014-09-26 22:54:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611513005/20001
6 years, 2 months ago (2014-09-29 23:03:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/19028)
6 years, 2 months ago (2014-09-30 00:47:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611513005/40001
6 years, 2 months ago (2014-09-30 16:58:17 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/3647)
6 years, 2 months ago (2014-09-30 17:12:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611513005/60001
6 years, 2 months ago (2014-09-30 17:16:39 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/20380)
6 years, 2 months ago (2014-09-30 17:30:01 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611513005/60001
6 years, 2 months ago (2014-09-30 17:32:50 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 3b0792d0bffdb7fe0bd668334a16281fe11cc7b4
6 years, 2 months ago (2014-09-30 22:17:47 UTC) #21
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/2983dc91cc0bc7be6014f4bfc5cb19cc6e262a0b Cr-Commit-Position: refs/heads/master@{#297523}
6 years, 2 months ago (2014-09-30 22:18:38 UTC) #22
Zhenyao Mo
6 years, 2 months ago (2014-09-30 23:18:23 UTC) #23
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/616183002/ by zmo@chromium.org.

The reason for reverting is: This broke
media/encrypted-media/encrypted-media-needkey.html on Linux (at least).

Powered by Google App Engine
This is Rietveld 408576698