Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 611513003: Disable DelegateGetFontList test on Android through C++. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, M-A Ruel, bulach, tony
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable DelegateGetFontList test on Android through C++. Instead of disabling it through a file under build/android, better to disable it directory in C++ source code to avoid sutle issues in the bots that was caused when renaming the test or the test suite target name. BUG=339980 TEST=ui_unittests_apk R=sky@chromium.org,primiano@chromium.org Committed: https://crrev.com/4642d9377d3044c81d0f32298ba0c203976c8cc9 Cr-Commit-Position: refs/heads/master@{#297637}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
D build/android/pylib/gtest/filter/ui_unittests_disabled View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
tfarina
See https://codereview.chromium.org/603413002/ for the findings.
6 years, 2 months ago (2014-09-26 19:35:11 UTC) #1
Primiano Tucci (use gerrit)
Not an owner of ui/base but the change LGTM. Just to double check if I ...
6 years, 2 months ago (2014-09-29 09:25:06 UTC) #2
tfarina
On 2014/09/29 09:25:06, Primiano Tucci wrote: > Not an owner of ui/base but the change ...
6 years, 2 months ago (2014-09-29 13:10:15 UTC) #3
tfarina
Scott, ping? I need your approval for ui/ to land this. Thanks,
6 years, 2 months ago (2014-09-30 20:37:15 UTC) #4
sky
LGTM
6 years, 2 months ago (2014-09-30 21:42:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611513003/20001
6 years, 2 months ago (2014-10-01 02:16:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/17840)
6 years, 2 months ago (2014-10-01 04:11:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611513003/20001
6 years, 2 months ago (2014-10-01 13:07:14 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 5f1a78550394a218e4108a7ee90375ea4acf2d7b
6 years, 2 months ago (2014-10-01 13:47:48 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 13:48:45 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4642d9377d3044c81d0f32298ba0c203976c8cc9
Cr-Commit-Position: refs/heads/master@{#297637}

Powered by Google App Engine
This is Rietveld 408576698