Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 611493002: Revert of Reland 588523002: Fix the way how we create webrtc::AudioProcessing in Chrome (Closed)

Created:
6 years, 2 months ago by no longer working on chromium
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland 588523002: Fix the way how we create webrtc::AudioProcessing in Chrome (patchset #5 id:80001 of https://codereview.chromium.org/597923002/) Reason for revert: It fails some aec dump content browser tests on windows, and likely it also breaks the aec dump production code, it is safer to revert it since cut happens today. http://chromegw.corp.google.com/i/internal.chromium.webrtc/builders/Win7%20Tester/builds/9752/steps/content_browsertests/logs/stdio Original issue's description: > The original review thread is in https://codereview.chromium.org/588523002/ > > Fix the way how we create webrtc::AudioProcessing in Chrome. > > TBR=tommi@chromium.org > > BUG=415935 > TEST=all webrtc tests in all bots + manual test to verify the agc loggings exist. > > Committed: https://chromium.googlesource.com/chromium/src/+/5ac9f35c3e5d9781a01769f3f0d0433026c57de7 TBR=tommi@chromium.org,jochen@chromium.org,maruel@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true BUG=415935 Committed: https://crrev.com/058a229c7120b29657a8967c6de2ff3d05cfc29d Cr-Commit-Position: refs/heads/master@{#296933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -71 lines) Patch
M build/android/pylib/gtest/setup.py View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -15 lines 0 comments Download
M content/content_unittests.isolate View 2 chunks +0 lines, -14 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor.cc View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/libjingle/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libjingle/overrides/init_webrtc.h View 4 chunks +1 line, -12 lines 0 comments Download
M third_party/libjingle/overrides/init_webrtc.cc View 5 chunks +1 line, -20 lines 0 comments Download
M third_party/libjingle/overrides/initialize_module.cc View 3 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
no longer working on chromium
Created Revert of Reland 588523002: Fix the way how we create webrtc::AudioProcessing in Chrome
6 years, 2 months ago (2014-09-26 14:02:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611493002/1
6 years, 2 months ago (2014-09-26 14:03:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7883befdd23152a19cb85b6c9497c334fd734c7c
6 years, 2 months ago (2014-09-26 14:04:01 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 14:04:44 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/058a229c7120b29657a8967c6de2ff3d05cfc29d
Cr-Commit-Position: refs/heads/master@{#296933}

Powered by Google App Engine
This is Rietveld 408576698