Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 611473004: Get rid of deprecated live regions code from ChromeVox (Closed)

Created:
6 years, 2 months ago by dmazzoni
Modified:
6 years, 2 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Get rid of deprecated live regions code from ChromeVox BUG=none Committed: https://crrev.com/0021c75dcf064f215c7a61888ef28258603618bb Cr-Commit-Position: refs/heads/master@{#297526}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -367 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher.js View 1 9 chunks +21 lines, -123 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions_deprecated.js View 1 chunk +0 lines, -244 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dmazzoni
Whoever wants to review first...
6 years, 2 months ago (2014-09-26 18:54:01 UTC) #2
Peter Lundblad
lgtm
6 years, 2 months ago (2014-09-29 15:24:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611473004/20001
6 years, 2 months ago (2014-09-30 21:18:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4751d4a8dfda772cc189f1836e4cea9d98ab810c
6 years, 2 months ago (2014-09-30 22:19:41 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 22:20:52 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0021c75dcf064f215c7a61888ef28258603618bb
Cr-Commit-Position: refs/heads/master@{#297526}

Powered by Google App Engine
This is Rietveld 408576698