Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 611463004: Disable paddles for DOM Distiller. (Closed)

Created:
6 years, 2 months ago by nyquist
Modified:
6 years, 2 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable paddles for DOM Distiller. Currently paddles show up when distilling a web page. This CL disables that part of the feature, to ensure no paddles show up. BUG=418240 Committed: https://crrev.com/cb544ae4df7b46966813be828e6107c7f74dd76c Cr-Commit-Position: refs/heads/master@{#297049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerFeedbackReporter.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
nyquist
yfriedman: PTAL
6 years, 2 months ago (2014-09-26 20:44:45 UTC) #2
Yaron
lgtm
6 years, 2 months ago (2014-09-26 21:12:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611463004/1
6 years, 2 months ago (2014-09-26 21:13:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9841d7b5e31ba85ab845e17be67ebe7157ef8999
6 years, 2 months ago (2014-09-26 22:05:55 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 22:07:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb544ae4df7b46966813be828e6107c7f74dd76c
Cr-Commit-Position: refs/heads/master@{#297049}

Powered by Google App Engine
This is Rietveld 408576698