Source/bindings/templates/methods.cpp - Issue 611453002: IDL: Clean up argument conversion error handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/methods.cpp

Issue 611453002: IDL: Clean up argument conversion error handling (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/templates/methods.cpp

diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp

index 1d9471034afb5256293289003c60baad9f22e673..94b70730869b707916dfc76315938738c13565d4 100644

--- a/Source/bindings/templates/methods.cpp

+++ b/Source/bindings/templates/methods.cpp

@@ -63,10 +63,6 @@ static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const

{{generate_argument_var_declaration(argument)}};

{% endfor %}

{

- {% if method.arguments_need_try_catch %}

- v8::TryCatch block;

- V8RethrowTryCatchScope rethrow(block);

- {% endif %}

{% for argument in method.arguments %}

{% if argument.default_value %}

if (!info[{{argument.index}}]->IsUndefined()) {