Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 611453002: IDL: Clean up argument conversion error handling (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/v8_methods.py
diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py
index dcf18d8cc715d89e3d4cc7d8718aef5553c2b09d..2fcb88633c3a5af04ddc72f54677fba89e3ac992 100644
--- a/Source/bindings/scripts/v8_methods.py
+++ b/Source/bindings/scripts/v8_methods.py
@@ -52,34 +52,6 @@ CUSTOM_REGISTRATION_EXTENDED_ATTRIBUTES = frozenset([
])
-def argument_needs_try_catch(method, argument):
- idl_type = argument.idl_type
- base_type = idl_type.base_type
-
- return not(
- # These cases are handled by separate code paths in the
- # generate_argument() macro in Source/bindings/templates/methods.cpp.
- idl_type.is_callback_interface or
- base_type == 'SerializedScriptValue' or
- (argument.is_variadic and idl_type.is_wrapper_type) or
- # Variadic arguments use toImplArguments() with throws excentions via
- # its ExceptionState& argument.
- argument.is_variadic or
- # String and enumeration arguments converted using one of the
- # TOSTRING_* macros except for _PROMISE variants in
- # Source/bindings/core/v8/V8BindingMacros.h don't use a v8::TryCatch.
- ((base_type == 'DOMString' or idl_type.is_enum) and
- not method.returns_promise) or
- # Conversion that take an ExceptionState& argument throw all their
- # exceptions via it, and doesn't need/use a TryCatch, except if the
- # argument has [Clamp], in which case it uses a separate code path in
- # Source/bindings/templates/methods.cpp, which *does* use a TryCatch.
- argument_conversion_needs_exception_state(method, argument) or
- # A trivial conversion cannot throw exceptions at all, so doesn't need a
- # TryCatch to catch them.
- idl_type.v8_conversion_is_trivial)
-
-
def use_local_result(method):
extended_attributes = method.extended_attributes
idl_type = method.idl_type
@@ -142,17 +114,12 @@ def method_context(interface, method):
is_raises_exception = 'RaisesException' in extended_attributes
- arguments_need_try_catch = (
- any(argument_needs_try_catch(method, argument)
- for argument in arguments))
-
return {
'activity_logging_world_list': v8_utilities.activity_logging_world_list(method), # [ActivityLogging]
'arguments': [argument_context(interface, method, argument, index)
for index, argument in enumerate(arguments)],
'argument_declarations_for_private_script':
argument_declarations_for_private_script(interface, method),
- 'arguments_need_try_catch': arguments_need_try_catch,
'conditional_string': v8_utilities.conditional_string(method),
'cpp_type': (v8_types.cpp_template_type('Nullable', idl_type.cpp_type)
if idl_type.is_explicit_nullable else idl_type.cpp_type),

Powered by Google App Engine
This is Rietveld 408576698