Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 611433002: Implementing WebRTC audio quality test for Mac. (Closed)

Created:
6 years, 2 months ago by phoglund_chromium
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Implementing WebRTC audio quality test for Mac. This makes the test described in http://goo.gl/umvzMt run on Mac. It relies on Soundflower to loop audio from output to input so that rec picks up the right audio. The new gs resource files have been added to their respective buckets. Note: this patch doesn't enable the tests. I need to configure the bots first with sox and soundflower before I do that. BUG=418034 Committed: https://crrev.com/d5597f9c656723040a1c04b2710f64fbd6f5041e Cr-Commit-Position: refs/heads/master@{#296917}

Patch Set 1 #

Patch Set 2 : Added instructions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc View 1 6 chunks +39 lines, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/human-voice-mac.wav.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/README View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/test/data/webrtc/resources/tools/pesq_mac.sha1 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
phoglund_chromium
6 years, 2 months ago (2014-09-26 09:28:17 UTC) #2
phoglund_chromium
6 years, 2 months ago (2014-09-26 10:04:06 UTC) #4
vrk (LEFT CHROMIUM)
lgtm
6 years, 2 months ago (2014-09-26 10:09:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611433002/20001
6 years, 2 months ago (2014-09-26 10:10:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b08dd0e8cfaed125800b6399c780013946ea475e
6 years, 2 months ago (2014-09-26 11:19:18 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 11:19:58 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5597f9c656723040a1c04b2710f64fbd6f5041e
Cr-Commit-Position: refs/heads/master@{#296917}

Powered by Google App Engine
This is Rietveld 408576698