Issue 611393004: Merged FeedbackSlotInterface into AstNode, removing the need for a 2nd vtable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 611393004: Merged FeedbackSlotInterface into AstNode, removing the need for a 2nd vtable. (Closed)

Created:
6 years, 2 months ago by Sven Panne

Modified:
6 years, 2 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Merged FeedbackSlotInterface into AstNode, removing the need for a 2nd vtable. This tiny change shaves off 112MB from the peak memory usage in the bug mentioned below, more to come... BUG=417697 LOG=y R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24390

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -49 lines)			Patch
M	src/ast.h	View	10 chunks	+19 lines, -10 lines	0 comments	Download
D	src/feedback-slots.h	View	1 chunk	+0 lines, -27 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	7 chunks	+8 lines, -12 lines	0 comments	Download

Total messages: 4 (1 generated)

Sven Panne

6 years, 2 months ago (2014-10-02 09:38:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 24390 (presubmit successful).