Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3034)

Unified Diff: base/android/library_loader/library_loader_hooks.h

Issue 611393002: Rationalize and fix chromium android linker histogram recording. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/library_loader/library_loader_hooks.h
diff --git a/base/android/library_loader/library_loader_hooks.h b/base/android/library_loader/library_loader_hooks.h
index 72935cf816208653dbb82551e03a8c0f29e80bfd..a8059affea05671cc6dfabf948d15f27f1efb74f 100644
--- a/base/android/library_loader/library_loader_hooks.h
+++ b/base/android/library_loader/library_loader_hooks.h
@@ -12,6 +12,18 @@
namespace base {
namespace android {
+// Register whether loading a renderer at a fixed address failed in the
+// chromium android linker. This value cannot be recorded when it arises
+// because histogram reporting is not available that early in the process
+// lifecycle. A call to this function retains the value, for later recording
+// as a histogram.
+BASE_EXPORT void RegisterChromiumAndroidLinkerRendererHistogram(
+ bool load_at_fixed_address_failed);
+
+// Record a value passed to RegisterChromiumAndroidLinkerRendererHistogram
+// as a histogram.
+BASE_EXPORT void RecordChromiumAndroidLinkerRendererHistogram();
+
// Registers the callbacks that allows the entry point of the library to be
// exposed to the calling java code. This handles only registering the
// the callbacks needed by the loader. Any application specific JNI bindings

Powered by Google App Engine
This is Rietveld 408576698