Clear user session flags before restarting Chrome for guest mode

Clear user session flags before restarting Chrome for guest mode

This avoids early restart to apply guest profile user flags
if device owner has some flags set.

BUG=411049
TEST=
1. Login as the device owner and set some flags in about::flags
2. Log out and enter guest mode
3.1. Press alt + shift + I -> Feedback report dialog should be launched
3.2. In chrome://help click "Report an issue" -> Feedback report dialog
should be launched

Committed: https://crrev.com/6d934345e2030aed1e6d831fad0c6b859c1e9600
Cr-Commit-Position: refs/heads/master@{#297920}

[tbarzic, 2014-10-01 02:42:29]

tbarzic@chromium.org changed reviewers:
+ alemate@chromium.org

[Alexander Alekseev, 2014-10-02 12:34:51]

lgtm with nit (please, add comment).

https://codereview.chromium.org/611383007/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/login_utils.cc (right):

https://codereview.chromium.org/611383007/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/login_utils.cc:427:
DBusThreadManager::Get()->GetSessionManagerClient()->SetFlagsForUser(
dpolukhin> Restarting browser twice for entering Guest mode is obvious
dpolukhin> wrong thing. So now I understand your patch that eliminates
dpolukhin> second restart. I think you should just update the comment
dpolukhin> what happens and good to go. It was really tricky issue!

Please add comment on what's happening here.

[tbarzic, 2014-10-02 20:23:55]

https://codereview.chromium.org/611383007/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/login_utils.cc (right):

https://codereview.chromium.org/611383007/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/login_utils.cc:427:
DBusThreadManager::Get()->GetSessionManagerClient()->SetFlagsForUser(
On 2014/10/02 12:34:51, Alexander Alekseev wrote:
> dpolukhin> Restarting browser twice for entering Guest mode is obvious
> dpolukhin> wrong thing. So now I understand your patch that eliminates
> dpolukhin> second restart. I think you should just update the comment
> dpolukhin> what happens and good to go. It was really tricky issue!
> 
> Please add comment on what's happening here.

Done.

[Alexander Alekseev, 2014-10-02 21:08:45]

lgtm

[tbarzic, 2014-10-02 21:30:55]

The CQ bit was checked by tbarzic@chromium.org

[commit-bot: I haz the power, 2014-10-02 21:33:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/611383007/40001

[commit-bot: I haz the power, 2014-10-02 22:04:35]

Committed patchset #3 (id:40001) as 1eae48f47a9bb86dd01f6afccbfef14a51ad3ef9

[commit-bot: I haz the power, 2014-10-02 22:05:36]

Patchset 3 (id:??) landed as
https://crrev.com/6d934345e2030aed1e6d831fad0c6b859c1e9600
Cr-Commit-Position: refs/heads/master@{#297920}