Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 611333002: Revert of Remove unused sourceData variable in InspectorStyleSheet. (Closed)

Created:
6 years, 2 months ago by vsevik
Modified:
6 years, 2 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Revert of Remove unused sourceData variable in InspectorStyleSheet. (patchset #1 id:1 of https://codereview.chromium.org/574963002/) Reason for revert: This code is still needed Original issue's description: > Remove unused sourceData variable in InspectorStyleSheet. > > Breaks build for targets that treat unused variables as errors. > > R=dgozman@chromium.org, vsevik@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182145 TBR=dgozman@chromium.org,ager@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182928

Patch Set 1 #

Patch Set 2 : Replace ASSERT with ASSERT_UNUSED #

Patch Set 3 : Fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/core/inspector/InspectorStyleSheet.cpp View 1 2 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
vsevik
Created Revert of Remove unused sourceData variable in InspectorStyleSheet.
6 years, 2 months ago (2014-09-30 12:18:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611333002/40001
6 years, 2 months ago (2014-09-30 12:22:42 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/21059)
6 years, 2 months ago (2014-09-30 12:33:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611333002/60001
6 years, 2 months ago (2014-09-30 12:41:46 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 14:25:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as 182928

Powered by Google App Engine
This is Rietveld 408576698