Issue 611323003: [SyncFS] Fix backgrounding race of ConflictResolver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 611323003: [SyncFS] Fix backgrounding race of ConflictResolver (Closed)

Created:
6 years, 2 months ago by tzik

Modified:
6 years, 2 months ago

Reviewers:
peria

CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik

Base URL:
https://chromium.googlesource.com/chromium/src.git@demotion

Project:
chromium

Visibility:
Public.

More Reviews

Description

[SyncFS] Fix backgrounding race of ConflictResolver The NOTREACHED is actually reached when parallelization is enabled. This CL fixes its handling. BUG=344769 Committed: https://crrev.com/9037ad79737667cd277c7789b65db1066cad0586 Cr-Commit-Position: refs/heads/master@{#297618}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	chrome/browser/sync_file_system/drive_backend/conflict_resolver.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	chrome/browser/sync_file_system/drive_backend/sync_worker.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611323003/1

6 years, 2 months ago (2014-10-01 08:41:40 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 37817b59e85e1762f28eb5560ab30d5f8507fc5d

6 years, 2 months ago (2014-10-01 09:41:31 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-10-01 09:42:04 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9037ad79737667cd277c7789b65db1066cad0586
Cr-Commit-Position: refs/heads/master@{#297618}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages