Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1412)

Side by Side Diff: ui/android/java/src/org/chromium/ui/VSyncMonitor.java

Issue 611313003: Use estimated vsync period on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused constant Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.ui; 5 package org.chromium.ui;
6 6
7 import android.annotation.SuppressLint; 7 import android.annotation.SuppressLint;
8 import android.content.Context; 8 import android.content.Context;
9 import android.os.Build; 9 import android.os.Build;
10 import android.os.Handler; 10 import android.os.Handler;
11 import android.view.Choreographer; 11 import android.view.Choreographer;
12 import android.view.WindowManager; 12 import android.view.WindowManager;
13 13
14 import org.chromium.base.TraceEvent; 14 import org.chromium.base.TraceEvent;
15 15
16 /** 16 /**
17 * Notifies clients of the default displays's vertical sync pulses. 17 * Notifies clients of the default displays's vertical sync pulses.
18 * On ICS, VSyncMonitor relies on setVSyncPointForICS() being called to set a re asonable 18 * On ICS, VSyncMonitor relies on setVSyncPointForICS() being called to set a re asonable
19 * approximation of a vertical sync starting point; see also http://crbug.com/15 6397. 19 * approximation of a vertical sync starting point; see also http://crbug.com/15 6397.
20 */ 20 */
21 @SuppressLint("NewApi") 21 @SuppressLint("NewApi")
22 public class VSyncMonitor { 22 public class VSyncMonitor {
23 private static final long NANOSECONDS_PER_SECOND = 1000000000; 23 private static final long NANOSECONDS_PER_SECOND = 1000000000;
24 private static final long NANOSECONDS_PER_MILLISECOND = 1000000; 24 private static final long NANOSECONDS_PER_MILLISECOND = 1000000;
25 private static final long NANOSECONDS_PER_MICROSECOND = 1000; 25 private static final long NANOSECONDS_PER_MICROSECOND = 1000;
26 26
27 private boolean mInsideVSync = false; 27 private boolean mInsideVSync = false;
28 28
29 // Conservative guess about vsync's consecutivity.
30 // If true, next tick is guaranteed to be consecutive.
31 private boolean mConsecutiveVSync = false;
32
29 /** 33 /**
30 * VSync listener class 34 * VSync listener class
31 */ 35 */
32 public interface Listener { 36 public interface Listener {
33 /** 37 /**
34 * Called very soon after the start of the display's vertical sync perio d. 38 * Called very soon after the start of the display's vertical sync perio d.
35 * @param monitor The VSyncMonitor that triggered the signal. 39 * @param monitor The VSyncMonitor that triggered the signal.
36 * @param vsyncTimeMicros Absolute frame time in microseconds. 40 * @param vsyncTimeMicros Absolute frame time in microseconds.
37 */ 41 */
38 public void onVSync(VSyncMonitor monitor, long vsyncTimeMicros); 42 public void onVSync(VSyncMonitor monitor, long vsyncTimeMicros);
39 } 43 }
40 44
41 private Listener mListener; 45 private Listener mListener;
42 46
43 // Display refresh rate as reported by the system. 47 // Display refresh rate as reported by the system.
44 private final long mRefreshPeriodNano; 48 private long mRefreshPeriodNano;
45 49
46 private boolean mHaveRequestInFlight; 50 private boolean mHaveRequestInFlight;
47 51
48 // Choreographer is used to detect vsync on >= JB. 52 // Choreographer is used to detect vsync on >= JB.
49 private final Choreographer mChoreographer; 53 private final Choreographer mChoreographer;
50 private final Choreographer.FrameCallback mVSyncFrameCallback; 54 private final Choreographer.FrameCallback mVSyncFrameCallback;
51 55
52 // On ICS we just post a task through the handler (http://crbug.com/156397) 56 // On ICS we just post a task through the handler (http://crbug.com/156397)
53 private final Runnable mVSyncRunnableCallback; 57 private final Runnable mVSyncRunnableCallback;
54 private long mGoodStartingPointNano; 58 private long mGoodStartingPointNano;
(...skipping 17 matching lines...) Expand all
72 /** 76 /**
73 * Constructs a VSyncMonitor 77 * Constructs a VSyncMonitor
74 * @param context The application context. 78 * @param context The application context.
75 * @param listener The listener receiving VSync notifications. 79 * @param listener The listener receiving VSync notifications.
76 * @param enableJBVsync Whether to allow Choreographer-based notifications o n JB and up. 80 * @param enableJBVsync Whether to allow Choreographer-based notifications o n JB and up.
77 */ 81 */
78 public VSyncMonitor(Context context, VSyncMonitor.Listener listener, boolean enableJBVSync) { 82 public VSyncMonitor(Context context, VSyncMonitor.Listener listener, boolean enableJBVSync) {
79 mListener = listener; 83 mListener = listener;
80 float refreshRate = ((WindowManager) context.getSystemService(Context.WI NDOW_SERVICE)) 84 float refreshRate = ((WindowManager) context.getSystemService(Context.WI NDOW_SERVICE))
81 .getDefaultDisplay().getRefreshRate(); 85 .getDefaultDisplay().getRefreshRate();
86 final boolean useEstimatedRefreshPeriod = refreshRate < 30;
87
82 if (refreshRate <= 0) refreshRate = 60; 88 if (refreshRate <= 0) refreshRate = 60;
83 mRefreshPeriodNano = (long) (NANOSECONDS_PER_SECOND / refreshRate); 89 mRefreshPeriodNano = (long) (NANOSECONDS_PER_SECOND / refreshRate);
84 90
85 if (enableJBVSync && Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_ BEAN) { 91 if (enableJBVSync && Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_ BEAN) {
86 // Use Choreographer on JB+ to get notified of vsync. 92 // Use Choreographer on JB+ to get notified of vsync.
87 mChoreographer = Choreographer.getInstance(); 93 mChoreographer = Choreographer.getInstance();
88 mVSyncFrameCallback = new Choreographer.FrameCallback() { 94 mVSyncFrameCallback = new Choreographer.FrameCallback() {
89 @Override 95 @Override
90 public void doFrame(long frameTimeNanos) { 96 public void doFrame(long frameTimeNanos) {
91 TraceEvent.begin("VSync"); 97 TraceEvent.begin("VSync");
98 if (useEstimatedRefreshPeriod && mConsecutiveVSync) {
99 // Display.getRefreshRate() is unreliable on some platfo rms.
100 // Adjust refresh period- initial value is based on Disp lay.getRefreshRate()
101 // after that it asymptotically approaches the real valu e.
102 long lastRefreshDurationNano = frameTimeNanos - mGoodSta rtingPointNano;
103 float lastRefreshDurationWeight = 0.1f;
104 mRefreshPeriodNano += (long) (lastRefreshDurationWeight *
105 (lastRefreshDurationNano - mRefreshPeriodNano));
106 }
92 mGoodStartingPointNano = frameTimeNanos; 107 mGoodStartingPointNano = frameTimeNanos;
93 onVSyncCallback(frameTimeNanos, getCurrentNanoTime()); 108 onVSyncCallback(frameTimeNanos, getCurrentNanoTime());
94 TraceEvent.end("VSync"); 109 TraceEvent.end("VSync");
95 } 110 }
96 }; 111 };
97 mVSyncRunnableCallback = null; 112 mVSyncRunnableCallback = null;
98 } else { 113 } else {
99 // On ICS we just hope that running tasks is relatively predictable. 114 // On ICS we just hope that running tasks is relatively predictable.
100 mChoreographer = null; 115 mChoreographer = null;
101 mVSyncFrameCallback = null; 116 mVSyncFrameCallback = null;
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 } finally { 194 } finally {
180 mInsideVSync = false; 195 mInsideVSync = false;
181 } 196 }
182 } 197 }
183 198
184 private void postCallback() { 199 private void postCallback() {
185 if (mHaveRequestInFlight) return; 200 if (mHaveRequestInFlight) return;
186 mHaveRequestInFlight = true; 201 mHaveRequestInFlight = true;
187 if (postSyntheticVSync()) return; 202 if (postSyntheticVSync()) return;
188 if (isVSyncSignalAvailable()) { 203 if (isVSyncSignalAvailable()) {
204 mConsecutiveVSync = mInsideVSync;
189 mChoreographer.postFrameCallback(mVSyncFrameCallback); 205 mChoreographer.postFrameCallback(mVSyncFrameCallback);
190 } else { 206 } else {
191 postRunnableCallback(); 207 postRunnableCallback();
192 } 208 }
193 } 209 }
194 210
195 private boolean postSyntheticVSync() { 211 private boolean postSyntheticVSync() {
196 final long currentTime = getCurrentNanoTime(); 212 final long currentTime = getCurrentNanoTime();
197 // Only trigger a synthetic vsync if we've been idle for long enough and the upcoming real 213 // Only trigger a synthetic vsync if we've been idle for long enough and the upcoming real
198 // vsync is more than half a frame away. 214 // vsync is more than half a frame away.
(...skipping 18 matching lines...) Expand all
217 233
218 if (currentTime + delay <= mLastPostedNano + mRefreshPeriodNano / 2) { 234 if (currentTime + delay <= mLastPostedNano + mRefreshPeriodNano / 2) {
219 delay += mRefreshPeriodNano; 235 delay += mRefreshPeriodNano;
220 } 236 }
221 237
222 mLastPostedNano = currentTime + delay; 238 mLastPostedNano = currentTime + delay;
223 if (delay == 0) mHandler.post(mVSyncRunnableCallback); 239 if (delay == 0) mHandler.post(mVSyncRunnableCallback);
224 else mHandler.postDelayed(mVSyncRunnableCallback, delay / NANOSECONDS_PE R_MILLISECOND); 240 else mHandler.postDelayed(mVSyncRunnableCallback, delay / NANOSECONDS_PE R_MILLISECOND);
225 } 241 }
226 } 242 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698