Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issue 611253004: Fix pixeldated HiDPI Mac widgets with impl-side painting (Closed)

Created:
6 years, 2 months ago by ccameron
Modified:
6 years, 2 months ago
Reviewers:
reed2, reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix pixeldated HiDPI Mac widgets with impl-side painting Allow SkiaBitLockers to specify that they should record a bitmap at a specified scale. Callers that know that they will be replayed at a given scale factor can specify the final scale during record. BUG=408557 Committed: https://crrev.com/74565e75e8cc51f49b47dd26a2cabce85479b61e Cr-Commit-Position: refs/heads/master@{#297485}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporate review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M skia/ext/skia_utils_mac.h View 2 chunks +5 lines, -1 line 0 comments Download
M skia/ext/skia_utils_mac.mm View 1 4 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ccameron
Another tweak to this for impl-side painting.
6 years, 2 months ago (2014-09-30 18:54:46 UTC) #2
reed1
lgtm https://codereview.chromium.org/611253004/diff/1/skia/ext/skia_utils_mac.mm File skia/ext/skia_utils_mac.mm (right): https://codereview.chromium.org/611253004/diff/1/skia/ext/skia_utils_mac.mm#newcode458 skia/ext/skia_utils_mac.mm:458: matrix.postScale(bitmapScaleFactor_, bitmapScaleFactor_); nit : seems like we can ...
6 years, 2 months ago (2014-09-30 18:57:25 UTC) #4
ccameron
Thanks for the super-fast review! https://codereview.chromium.org/611253004/diff/1/skia/ext/skia_utils_mac.mm File skia/ext/skia_utils_mac.mm (right): https://codereview.chromium.org/611253004/diff/1/skia/ext/skia_utils_mac.mm#newcode458 skia/ext/skia_utils_mac.mm:458: matrix.postScale(bitmapScaleFactor_, bitmapScaleFactor_); On 2014/09/30 ...
6 years, 2 months ago (2014-09-30 19:01:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611253004/20001
6 years, 2 months ago (2014-09-30 19:02:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a237c0e227e1985d9772e108172e55f586e40acf
6 years, 2 months ago (2014-09-30 19:59:34 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 20:00:05 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/74565e75e8cc51f49b47dd26a2cabce85479b61e
Cr-Commit-Position: refs/heads/master@{#297485}

Powered by Google App Engine
This is Rietveld 408576698