Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 611253003: Introduct git-auto-svn (Closed)

Created:
6 years, 2 months ago by agable
Modified:
6 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Introduct git-auto-svn This tool can automatically set up the necessary git-svn metadata for our repos that live in SVN but are mirrored to Chrome. R=iannucci@chromium.org, tandrii@chromium.org BUG=418973 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=292241

Patch Set 1 #

Patch Set 2 : Docs #

Patch Set 3 : Better docs #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -67 lines) Patch
A + git-auto-svn View 0 chunks +-1 lines, --1 lines 2 comments Download
A git_auto_svn.py View 1 chunk +96 lines, -0 lines 0 comments Download
M git_common.py View 4 chunks +11 lines, -9 lines 0 comments Download
M git_footers.py View 1 chunk +2 lines, -0 lines 0 comments Download
A + man/html/git-auto-svn.html View 1 2 5 chunks +49 lines, -59 lines 0 comments Download
A man/man1/git-auto-svn.1 View 1 2 1 chunk +113 lines, -0 lines 0 comments Download
A man/src/_git-auto-svn_desc.helper.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A man/src/git-auto-svn.txt View 1 2 1 chunk +69 lines, -0 lines 4 comments Download
M man/src/make_docs.sh View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
agable
6 years, 2 months ago (2014-09-30 13:24:45 UTC) #1
tandrii(chromium)
LGTM So, the modifications in files are just PEP8-ing. Is that a considered a good ...
6 years, 2 months ago (2014-09-30 17:06:28 UTC) #3
tandrii(chromium)
My previous comment was for Patch Set #1. The doc looks good, too.
6 years, 2 months ago (2014-09-30 17:12:15 UTC) #4
iannucci
lgtm https://codereview.chromium.org/611253003/diff/40001/git-auto-svn File git-auto-svn (right): https://codereview.chromium.org/611253003/diff/40001/git-auto-svn#newcode6 git-auto-svn:6: # git_map_branches.py -- a git-command for presenting a ...
6 years, 2 months ago (2014-09-30 21:42:25 UTC) #5
agable
https://codereview.chromium.org/611253003/diff/40001/git-auto-svn File git-auto-svn (right): https://codereview.chromium.org/611253003/diff/40001/git-auto-svn#newcode6 git-auto-svn:6: # git_map_branches.py -- a git-command for presenting a graphical ...
6 years, 2 months ago (2014-10-01 09:35:59 UTC) #6
agable
6 years, 2 months ago (2014-10-01 09:40:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 292241.

Powered by Google App Engine
This is Rietveld 408576698