Rename the VideoPlayer-related string IDs

Rename the VideoPlayer-related string IDs

- FILE_BROWSER_GALLERY_VIDEO_ERROR -> VIDEO_PLAYER_VIDEO_FILE_UNSUPPORTED
- FILE_BROWSER_GALLERY_VIDEO_DECODING_ERROR -> VIDEO_PLAYER_PLAYBACK_ERROR
- FILE_BROWSER_GALLERY_VIDEO_LOOPED_MODE -> IDS_VIDEO_PLAYER_LOOPED_MODE

BUG=none
TEST=none

Committed: https://crrev.com/cde45198f38e66e185a212185fa4695071bd32d3
Cr-Commit-Position: refs/heads/master@{#300048}

[yoshiki, 2014-09-30 08:57:31]

yoshiki@chromium.org changed reviewers:
+ mtomasz@chromium.org

[yoshiki, 2014-09-30 08:58:12]

@mtomasz: PTAL. Thanks.

[mtomasz, 2014-09-30 09:17:08]

https://codereview.chromium.org/611243003/diff/20001/chrome/app/chromeos_stri...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/611243003/diff/20001/chrome/app/chromeos_stri...
chrome/app/chromeos_strings.grdp:948: <message
name="IDS_VIDEO_PLAYER_VIDEO_FILE_UNSUPPORTED" desc="In the video player app,
message informing that the video could not be played.">
"Unsupported" sounds strange. Shouldn't it be "not supported"? Please confirm
with some native speaker.

https://codereview.chromium.org/611243003/diff/20001/chrome/app/chromeos_stri...
chrome/app/chromeos_strings.grdp:955: An error occurred. Click to restart from
the beginning.
I don't understand difference between PLAYBACK_ERROR and FILE_UNSUPPORTED. Why
only one has the "click to restart from beginning" message? Shouldn't we add it
to each error?

[yoshiki, 2014-09-30 12:02:46]

https://codereview.chromium.org/611243003/diff/20001/chrome/app/chromeos_stri...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/611243003/diff/20001/chrome/app/chromeos_stri...
chrome/app/chromeos_strings.grdp:948: <message
name="IDS_VIDEO_PLAYER_VIDEO_FILE_UNSUPPORTED" desc="In the video player app,
message informing that the video could not be played.">
On 2014/09/30 09:17:08, mtomasz wrote:
> "Unsupported" sounds strange. Shouldn't it be "not supported"? Please confirm
> with some native speaker.

We are using the word 'unsupported' in many places in chromium. I think we can
use it.

https://codereview.chromium.org/611243003/diff/20001/chrome/app/chromeos_stri...
chrome/app/chromeos_strings.grdp:955: An error occurred. Click to restart from
the beginning.
On 2014/09/30 09:17:08, mtomasz wrote:
> I don't understand difference between PLAYBACK_ERROR and FILE_UNSUPPORTED. Why
> only one has the "click to restart from beginning" message? Shouldn't we add
it
> to each error?

PLAYBACK_ERROR is a kind of general error. In other words, it covers all sort of
playback errors except an unsupported error.

[mtomasz, 2014-10-01 07:12:58]

https://codereview.chromium.org/611243003/diff/20001/chrome/app/chromeos_stri...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/611243003/diff/20001/chrome/app/chromeos_stri...
chrome/app/chromeos_strings.grdp:948: <message
name="IDS_VIDEO_PLAYER_VIDEO_FILE_UNSUPPORTED" desc="In the video player app,
message informing that the video could not be played.">
On 2014/09/30 12:02:46, yoshiki wrote:
> On 2014/09/30 09:17:08, mtomasz wrote:
> > "Unsupported" sounds strange. Shouldn't it be "not supported"? Please
confirm
> > with some native speaker.
> 
> We are using the word 'unsupported' in many places in chromium. I think we can

OK

https://codereview.chromium.org/611243003/diff/20001/chrome/app/chromeos_stri...
chrome/app/chromeos_strings.grdp:955: An error occurred. Click to restart from
the beginning.
On 2014/09/30 12:02:46, yoshiki wrote:
> On 2014/09/30 09:17:08, mtomasz wrote:
> > I don't understand difference between PLAYBACK_ERROR and FILE_UNSUPPORTED.
Why
> > only one has the "click to restart from beginning" message? Shouldn't we add
> it
> > to each error?
> 
> PLAYBACK_ERROR is a kind of general error. In other words, it covers all sort
of
> playback errors except an unsupported error. 


Got it. Shall we add "Click to restart from the beginning." to the
UNSUPPORTED_FOR_CAST error message?

[mtomasz, 2014-10-01 08:55:24]

On 2014/10/01 07:12:58, mtomasz wrote:
>
https://codereview.chromium.org/611243003/diff/20001/chrome/app/chromeos_stri...
> File chrome/app/chromeos_strings.grdp (right):
> 
>
https://codereview.chromium.org/611243003/diff/20001/chrome/app/chromeos_stri...
> chrome/app/chromeos_strings.grdp:948: <message
> name="IDS_VIDEO_PLAYER_VIDEO_FILE_UNSUPPORTED" desc="In the video player app,
> message informing that the video could not be played.">
> On 2014/09/30 12:02:46, yoshiki wrote:
> > On 2014/09/30 09:17:08, mtomasz wrote:
> > > "Unsupported" sounds strange. Shouldn't it be "not supported"? Please
> confirm
> > > with some native speaker.
> > 
> > We are using the word 'unsupported' in many places in chromium. I think we
can
> 
> OK
> 
>
https://codereview.chromium.org/611243003/diff/20001/chrome/app/chromeos_stri...
> chrome/app/chromeos_strings.grdp:955: An error occurred. Click to restart from
> the beginning.
> On 2014/09/30 12:02:46, yoshiki wrote:
> > On 2014/09/30 09:17:08, mtomasz wrote:
> > > I don't understand difference between PLAYBACK_ERROR and FILE_UNSUPPORTED.
> Why
> > > only one has the "click to restart from beginning" message? Shouldn't we
add
> > it
> > > to each error?
> > 
> > PLAYBACK_ERROR is a kind of general error. In other words, it covers all
sort
> of
> > playback errors except an unsupported error. 
> 
> 
> Got it. Shall we add "Click to restart from the beginning." to the
> UNSUPPORTED_FOR_CAST error message?

Sorry, I was wrong. Since it's unsupported, then there is no reason to restart.
LGTM.

[yoshiki, 2014-10-16 17:14:51]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2014-10-16 17:16:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/611243003/20001

[commit-bot: I haz the power, 2014-10-16 18:01:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-16 18:01:09]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoshiki, 2014-10-17 02:06:39]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2014-10-17 02:08:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/611243003/40001

[commit-bot: I haz the power, 2014-10-17 02:44:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-17 02:45:40]

Patchset 3 (id:??) landed as
https://crrev.com/cde45198f38e66e185a212185fa4695071bd32d3
Cr-Commit-Position: refs/heads/master@{#300048}