Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 611233005: Supervised user blacklist: Make the cmdline flag an enable/disable type. (Closed)

Created:
6 years, 2 months ago by Marc Treib
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Supervised user blacklist: Make the cmdline flag an enable/disable value type. This gives the flag a possible value of "default", which will allow us to enable the feature for some users who haven't explicitly opted in/out. BUG=410824 Committed: https://crrev.com/63b9dc02b9b2516202e27b0f0555a37005bc5eab Cr-Commit-Position: refs/heads/master@{#297925}

Patch Set 1 #

Patch Set 2 : fix histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/about_flags.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Marc Treib
PTAL!
6 years, 2 months ago (2014-10-01 14:31:13 UTC) #2
Bernhard Bauer
lgtm
6 years, 2 months ago (2014-10-01 14:32:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611233005/1
6 years, 2 months ago (2014-10-01 14:33:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/14249)
6 years, 2 months ago (2014-10-01 15:24:40 UTC) #7
Marc Treib
+asvitkine: Once again, trivial addition to histograms.xml. Thanks!
6 years, 2 months ago (2014-10-01 15:35:17 UTC) #9
Alexei Svitkine (slow)
lgtm
6 years, 2 months ago (2014-10-02 20:48:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611233005/20001
6 years, 2 months ago (2014-10-02 20:50:53 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 58e5d4fbbcda3c2188bcbb66ec6229c1d1d21fa2
6 years, 2 months ago (2014-10-02 22:30:24 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 22:31:07 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63b9dc02b9b2516202e27b0f0555a37005bc5eab
Cr-Commit-Position: refs/heads/master@{#297925}

Powered by Google App Engine
This is Rietveld 408576698