Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 611233004: Reland "Unit test for sync online wallpaper" (Closed)

Created:
6 years, 2 months ago by bshe
Modified:
6 years, 2 months ago
Reviewers:
M-A Ruel, kevers
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland "Unit test for sync online wallpaper" Reland Unit test for sync online wallpaper (https://codereview.chromium.org/618743003/) It was reverted because failure on linux_chromium_os with this error: [7412:7412:0930/164710:INFO:CONSOLE(180)] "ReferenceError: Constants is not defined at testSyncOnlineWallpaper (file:///tmp/run_tha_teste4P5jV/chrome/test/data/chromeos/wallpaper_manager/unit_tests/event_page_unittest.js:24:11) at continueTesting (\u003Canonymous>:177:19) at runTests (\u003Canonymous>:153:5) at \u003Canonymous>:1:51", source: (180) ../../chrome/browser/chromeos/extensions/wallpaper_manager_browsertest.cc:89: Failure Value of: ExecuteWebUIResourceTest(web_contents, empty_libraries) Actual: false Expected: true BUG=416130 Committed: https://crrev.com/09d4967a8d18931a28bc57f94cf7dfe416d69486 Cr-Commit-Position: refs/heads/master@{#297942}

Patch Set 1 #

Patch Set 2 : Add relative files to isolate #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -3 lines) Patch
M chrome/browser/chromeos/extensions/wallpaper_manager_browsertest.cc View 2 chunks +25 lines, -0 lines 0 comments Download
M chrome/browser_tests.isolate View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/chromeos/wallpaper_manager/unit_tests/api_mock.js View 1 2 1 chunk +133 lines, -0 lines 0 comments Download
A chrome/test/data/chromeos/wallpaper_manager/unit_tests/event_page_unittest.html View 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/test/data/chromeos/wallpaper_manager/unit_tests/event_page_unittest.js View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
M chrome/test/data/webui/mock_controller.js View 5 chunks +30 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
bshe
+maruel and +kevers for browser_test.isolate file My CL previous failed on swarming bots and this ...
6 years, 2 months ago (2014-10-02 20:06:11 UTC) #3
M-A Ruel
browser_tests.isolate lgtm
6 years, 2 months ago (2014-10-02 20:07:57 UTC) #4
kevers
lgtm
6 years, 2 months ago (2014-10-02 20:23:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611233004/30001
6 years, 2 months ago (2014-10-02 20:48:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611233004/50001
6 years, 2 months ago (2014-10-02 23:00:03 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:50001) as 6e59eb2b7cc44e8e61b2b096e2babc564065a48e
6 years, 2 months ago (2014-10-02 23:13:02 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 23:14:27 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/09d4967a8d18931a28bc57f94cf7dfe416d69486
Cr-Commit-Position: refs/heads/master@{#297942}

Powered by Google App Engine
This is Rietveld 408576698