Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 611233002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/dom/custom (Closed)

Created:
6 years, 2 months ago by deepak.sa
Modified:
6 years, 2 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis, mlamouri (slow - plz ping)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/dom/custom Replace |FINAL| with |final| and |OVERRIDE| with |override| as per allowed C++11 features. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183248

Patch Set 1 #

Patch Set 2 : Rebased #

Messages

Total messages: 17 (6 generated)
deepak.sa
PTAL? Thanks!
6 years, 2 months ago (2014-09-30 09:21:24 UTC) #2
dominicc (has gone to gerrit)
On 2014/09/30 09:21:24, deepak.sa wrote: > PTAL? > Thanks! I haven't been following the C++ ...
6 years, 2 months ago (2014-10-01 14:19:11 UTC) #3
mlamouri (slow - plz ping)
On 2014/10/01 14:19:11, dominicc wrote: > On 2014/09/30 09:21:24, deepak.sa wrote: > > PTAL? > ...
6 years, 2 months ago (2014-10-02 10:21:46 UTC) #4
dominicc (has gone to gerrit)
LGTM On Oct 2, 2014 7:21 PM, <mlamouri@chromium.org> wrote: > On 2014/10/01 14:19:11, dominicc wrote: ...
6 years, 2 months ago (2014-10-02 15:44:07 UTC) #5
dominicc (has gone to gerrit)
lgtm
6 years, 2 months ago (2014-10-03 06:59:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611233002/1
6 years, 2 months ago (2014-10-03 07:00:13 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_dbg/builds/14689) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/63942)
6 years, 2 months ago (2014-10-03 07:03:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611233002/1
6 years, 2 months ago (2014-10-06 05:28:52 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_dbg/builds/14853) linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/75128) mac_gpu ...
6 years, 2 months ago (2014-10-06 05:31:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611233002/20001
6 years, 2 months ago (2014-10-06 06:29:17 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 07:35:16 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183248

Powered by Google App Engine
This is Rietveld 408576698