Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 611193002: Files.app: Fix DirectoryModel#partialUpdate so that it does not ignore changes. (Closed)

Created:
6 years, 2 months ago by hirono
Modified:
6 years, 2 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Files.app: Fix DirectoryModel#partialUpdate so that it does not ignore changes. Previously DirectoryModel#partialUpdate ignores changes if the function is called multiple times during the previous request is being procecced. BUG=417163 TEST=Repo steps of the bug. Committed: https://crrev.com/8ad2b71e4fc3f7a0ee4e4b378733c1f8c4bdf8fd Cr-Commit-Position: refs/heads/master@{#297381}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_model.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL the CL? Thank you!
6 years, 2 months ago (2014-09-30 02:32:05 UTC) #2
yoshiki
lgtm
6 years, 2 months ago (2014-09-30 06:55:17 UTC) #3
hirono
On 2014/09/30 06:55:17, yoshiki wrote: > lgtm Thanks!
6 years, 2 months ago (2014-09-30 07:51:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611193002/20001
6 years, 2 months ago (2014-09-30 07:52:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c96c95876dea4325acb8121f05c1b75aea9d3c01
6 years, 2 months ago (2014-09-30 08:30:18 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 08:31:18 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ad2b71e4fc3f7a0ee4e4b378733c1f8c4bdf8fd
Cr-Commit-Position: refs/heads/master@{#297381}

Powered by Google App Engine
This is Rietveld 408576698