Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1345)

Issue 611163003: Allow gcdPrivate on any channel. (Closed)

Created:
6 years, 2 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou, Andy, zentaro, mednik
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow gcdPrivate on any channel. There is no reason to hide private API. BUG=394124 Committed: https://crrev.com/7c61e0145f3e598ae7a9ac69159234d6ec7f6008 Cr-Commit-Position: refs/heads/master@{#297856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/extensions/api/_permission_features.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
Vitaly Buka (NO REVIEWS)
6 years, 2 months ago (2014-09-29 23:45:51 UTC) #2
mednik
lgtm
6 years, 2 months ago (2014-09-29 23:51:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611163003/1
6 years, 2 months ago (2014-10-02 17:21:48 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-02 17:21:51 UTC) #9
Vitaly Buka (NO REVIEWS)
6 years, 2 months ago (2014-10-02 17:29:42 UTC) #11
Yoyo Zhou
LGTM
6 years, 2 months ago (2014-10-02 17:35:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611163003/1
6 years, 2 months ago (2014-10-02 17:37:37 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as ca622edfee6bd160e8ee976450d1558131cda8c2
6 years, 2 months ago (2014-10-02 17:48:10 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 17:49:03 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c61e0145f3e598ae7a9ac69159234d6ec7f6008
Cr-Commit-Position: refs/heads/master@{#297856}

Powered by Google App Engine
This is Rietveld 408576698