Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1778)

Issue 611103002: Clean up pak loading. (Closed)

Created:
6 years, 2 months ago by Avi (use Gerrit)
Modified:
6 years, 2 months ago
Reviewers:
tony
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up pak loading. - kEmptyPakContents was malformed; fix it - chrome.pak was deleted half a year ago for iOS Chrome; don't try to load it BUG=410411 TEST=no visible change Committed: https://crrev.com/b34c55a6d60b5941fa54e2b214533cf8e5377675 Cr-Commit-Position: refs/heads/master@{#297210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M ui/base/resource/data_pack_literal.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/resource/resource_bundle_ios.mm View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Avi (use Gerrit)
I'm having trouble with the build machinery in https://codereview.chromium.org/537063002/ so I'm landing pieces separately. This ...
6 years, 2 months ago (2014-09-29 17:35:24 UTC) #2
tony
LGTM
6 years, 2 months ago (2014-09-29 17:47:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611103002/1
6 years, 2 months ago (2014-09-29 17:51:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as a6214ad10ff4a2119ba7ca5ddd4896995f67b3b5
6 years, 2 months ago (2014-09-29 18:20:01 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 18:21:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b34c55a6d60b5941fa54e2b214533cf8e5377675
Cr-Commit-Position: refs/heads/master@{#297210}

Powered by Google App Engine
This is Rietveld 408576698