Issue 6111001: Make a separated library for files common between webkit_support and test_she...

Issue 6111001: Make a separated library for files common between webkit_support and test_she... (Closed)

Created:
9 years, 11 months ago by tkent

Modified:
9 years, 7 months ago

Reviewers:
tony, Nico

CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make a separated library for files common between webkit_support and test_shell in order to avoid that test_shell links webkit_support-dedicated files. BUG=67457 TEST=none; No behavior change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71293

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -19 lines)			Patch
	M	webkit/support/webkit_support.gypi	View	1	4 chunks	+29 lines, -18 lines	0 comments	Download
	M	webkit/tools/test_shell/test_shell.gypi	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tony

Looks like windows had linking errors. http://codereview.chromium.org/6111001/diff/2001/webkit/support/webkit_support.gypi File webkit/support/webkit_support.gypi (right): http://codereview.chromium.org/6111001/diff/2001/webkit/support/webkit_support.gypi#newcode71 webkit/support/webkit_support.gypi:71: 'target_name': 'common', Can ...

9 years, 11 months ago (2011-01-11 17:45:21 UTC) #2

tkent

Thank you for reviewing. The updated patch seems to fix the Windows errors.

9 years, 11 months ago (2011-01-12 02:17:01 UTC) #3

tkent

http://codereview.chromium.org/6111001/diff/2001/webkit/support/webkit_support.gypi File webkit/support/webkit_support.gypi (right): http://codereview.chromium.org/6111001/diff/2001/webkit/support/webkit_support.gypi#newcode71 webkit/support/webkit_support.gypi:71: 'target_name': 'common', Yes! Done in the updated patch.

9 years, 11 months ago (2011-01-12 02:17:15 UTC) #4

LGTM

Expand Messages | Collapse Messages