Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 611093002: remove alphatype from colortable (Closed)

Created:
6 years, 2 months ago by reed1
Modified:
6 years, 2 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

remove alphatype from colortable the owning bitmap is (already) responsible for knowing the alphatype BUG=skia: Committed: https://skia.googlesource.com/skia/+/c5e15a1afab2621e860a251c3fcf5917867ad49f

Patch Set 1 #

Patch Set 2 : bump picture version #

Total comments: 2

Patch Set 3 : update codecs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -75 lines) Patch
M bench/BitmapBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/RepeatTileBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkColorTable.h View 3 chunks +5 lines, -11 lines 0 comments Download
M include/core/SkPicture.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M samplecode/SampleDitherBitmap.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/core/SkColorTable.cpp View 1 4 chunks +21 lines, -30 lines 0 comments Download
M src/core/SkReadBuffer.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/images/SkImageDecoder_libgif.cpp View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M src/images/SkImageDecoder_libpng.cpp View 1 2 1 chunk +1 line, -11 lines 0 comments Download
M src/images/SkImageDecoder_wbmp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/BitmapCopyTest.cpp View 3 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
reed1
6 years, 2 months ago (2014-09-29 17:28:58 UTC) #2
djsollen
https://codereview.chromium.org/611093002/diff/20001/src/images/SkImageDecoder_wbmp.cpp File src/images/SkImageDecoder_wbmp.cpp (left): https://codereview.chromium.org/611093002/diff/20001/src/images/SkImageDecoder_wbmp.cpp#oldcode122 src/images/SkImageDecoder_wbmp.cpp:122: SkColorTable* ct = SkNEW_ARGS(SkColorTable, (colors, 2, kOpaque_SkAlphaType)); the gif ...
6 years, 2 months ago (2014-09-29 17:57:45 UTC) #3
reed1
https://codereview.chromium.org/611093002/diff/20001/src/images/SkImageDecoder_wbmp.cpp File src/images/SkImageDecoder_wbmp.cpp (left): https://codereview.chromium.org/611093002/diff/20001/src/images/SkImageDecoder_wbmp.cpp#oldcode122 src/images/SkImageDecoder_wbmp.cpp:122: SkColorTable* ct = SkNEW_ARGS(SkColorTable, (colors, 2, kOpaque_SkAlphaType)); On 2014/09/29 ...
6 years, 2 months ago (2014-09-29 18:24:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611093002/40001
6 years, 2 months ago (2014-09-29 18:26:28 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-09-29 18:26:44 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-09-29 18:26:45 UTC) #8
djsollen
lgtm
6 years, 2 months ago (2014-09-29 18:30:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611093002/40001
6 years, 2 months ago (2014-09-29 19:10:15 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 19:10:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as c5e15a1afab2621e860a251c3fcf5917867ad49f

Powered by Google App Engine
This is Rietveld 408576698