Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 61103002: Enable WebrtcCastApiTest.Basics (Closed)

Created:
7 years, 1 month ago by Alpha Left Google
Modified:
7 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Enable WebrtcCastApiTest.Basics Enable the test now that the problem with build bot is resolved. BUG=314971 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233179

Patch Set 1 #

Patch Set 2 : fix js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M chrome/browser/extensions/webrtc_cast_apitest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/test/data/extensions/api_test/webrtc_cast/basics.js View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alpha Left Google
7 years, 1 month ago (2013-11-05 22:02:47 UTC) #1
not at google - send to devlin
it was actually failing before though, right? you should just unwind to disabled-on-win?
7 years, 1 month ago (2013-11-05 22:05:27 UTC) #2
Alpha Left Google
On 2013/11/05 22:05:27, kalman wrote: > it was actually failing before though, right? you should ...
7 years, 1 month ago (2013-11-05 22:08:54 UTC) #3
not at google - send to devlin
ah. lgtm.
7 years, 1 month ago (2013-11-05 22:09:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/61103002/30001
7 years, 1 month ago (2013-11-05 22:23:34 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 01:34:31 UTC) #6
Message was sent while issue was closed.
Change committed as 233179

Powered by Google App Engine
This is Rietveld 408576698