Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Issue 611023002: Mojo + GN: Fix missing dependencies in existing existing mojom targets. (Closed)

Created:
6 years, 2 months ago by ppi
Modified:
6 years, 2 months ago
Reviewers:
qsr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo + GN: Fix missing dependencies in existing existing mojom targets. Mojom targets containing files referencing imported entities need to depend on targets containing the imported .mojom files. This patch fixes existing omissions. BUG=417289 Committed: https://crrev.com/ba3242408648f7752ab08f20e3f26ac7f5576759 Cr-Commit-Position: refs/heads/master@{#297175}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M mojo/services/public/interfaces/gpu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/interfaces/input_events/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ppi
ptal
6 years, 2 months ago (2014-09-29 13:44:36 UTC) #2
qsr
lgtm
6 years, 2 months ago (2014-09-29 13:53:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611023002/1
6 years, 2 months ago (2014-09-29 13:59:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/8035)
6 years, 2 months ago (2014-09-29 14:42:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611023002/1
6 years, 2 months ago (2014-09-29 14:46:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 37f5257b28c1e8b9dccc3f9cba0fd3a1f7e37c1e
6 years, 2 months ago (2014-09-29 15:06:51 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 15:07:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba3242408648f7752ab08f20e3f26ac7f5576759
Cr-Commit-Position: refs/heads/master@{#297175}

Powered by Google App Engine
This is Rietveld 408576698