Issue 611013003: Remove unnecessary deps on base_static in mojo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 611013003: Remove unnecessary deps on base_static in mojo (Closed)

Created:
6 years, 2 months ago by DaveMoore

Modified:
6 years, 2 months ago

Reviewers:
jamesr

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove unnecessary deps on base_static in mojo BUG= Committed: https://crrev.com/ec532179d3934908bc13035f5947fcba897c6e15 Cr-Commit-Position: refs/heads/master@{#297296}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -6 lines)			Patch
M	mojo/mojo.gyp	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	mojo/shell/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/spy/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/views/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611013003/1

6 years, 2 months ago (2014-09-29 21:53:55 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as bb0aa4e7d5b4517a1090ffd80a00c72de72b3351

6 years, 2 months ago (2014-09-29 22:56:57 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-09-29 23:00:23 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ec532179d3934908bc13035f5947fcba897c6e15
Cr-Commit-Position: refs/heads/master@{#297296}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages