Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 611013002: Rebaseline for findbugs for Android. (Closed)

Created:
6 years, 2 months ago by Fabrice (no longer in Chrome)
Modified:
6 years, 2 months ago
Reviewers:
Yaron, ppi
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rebaseline for findbugs for Android. BUG=418549 NOTRY=true Committed: https://crrev.com/26fb9711a189ed3c49ae90873981e074c38534b0 Cr-Commit-Position: refs/heads/master@{#297165}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 chunk +1 line, -4 lines 1 comment Download

Messages

Total messages: 11 (2 generated)
Fabrice (no longer in Chrome)
+yfriedman who is in the OWNERS for this file.
6 years, 2 months ago (2014-09-29 13:29:09 UTC) #2
Fabrice (no longer in Chrome)
Removing obsolete warnings and adding a new warning to turn the bots green. Sample output: ...
6 years, 2 months ago (2014-09-29 13:29:54 UTC) #3
ppi
https://codereview.chromium.org/611013002/diff/1/build/android/findbugs_filter/findbugs_known_bugs.txt File build/android/findbugs_filter/findbugs_known_bugs.txt (left): https://codereview.chromium.org/611013002/diff/1/build/android/findbugs_filter/findbugs_known_bugs.txt#oldcode23 build/android/findbugs_filter/findbugs_known_bugs.txt:23: M V EI2: org.chromium.content_public.browser.LoadUrlParams.setPostData(byte[]) may expose internal representation by ...
6 years, 2 months ago (2014-09-29 13:33:48 UTC) #4
ppi
Oh, please disregard the above, lgtm.
6 years, 2 months ago (2014-09-29 13:34:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611013002/1
6 years, 2 months ago (2014-09-29 13:36:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as b9efb71dea0e5cb7f00bb0279e8f8ee0534fe594
6 years, 2 months ago (2014-09-29 13:37:04 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/26fb9711a189ed3c49ae90873981e074c38534b0 Cr-Commit-Position: refs/heads/master@{#297165}
6 years, 2 months ago (2014-09-29 13:37:51 UTC) #9
Fabrice (no longer in Chrome)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/613653005/ by fdegans@chromium.org. ...
6 years, 2 months ago (2014-09-29 14:34:38 UTC) #10
sergeyv
6 years, 2 months ago (2014-09-29 14:36:57 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/617463002/ by sergeyv@chromium.org.

The reason for reverting is:
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Buil...

Android builder've started to failure after this change.

Powered by Google App Engine
This is Rietveld 408576698