Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 610973002: hr tag should have xml role as separator (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

hr tag should have xml role as separator According to specs hr tag should have xml role as separator. BUG=384723 Committed: https://crrev.com/1a9d3279f3f3a550c63d7144509f75110adc225e Cr-Commit-Position: refs/heads/master@{#297185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/hr.html View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/hr-expected-win.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review. Thanks!
6 years, 2 months ago (2014-09-29 13:02:21 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-09-29 15:11:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610973002/1
6 years, 2 months ago (2014-09-29 15:11:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 96c7dfb84c6ef86ac096329efa70ecf7629b5295
6 years, 2 months ago (2014-09-29 16:05:42 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 16:06:16 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1a9d3279f3f3a550c63d7144509f75110adc225e
Cr-Commit-Position: refs/heads/master@{#297185}

Powered by Google App Engine
This is Rietveld 408576698