Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 610913004: [Android] Handle a null java side of CVC in context menu (Closed)

Created:
6 years, 2 months ago by David Trainor- moved to gerrit
Modified:
6 years, 2 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Handle a null java side of CVC in context menu We might have a native ContentViewCore but not a java side. Don't attempt to show the context menu if this is the case. BUG=410599 Committed: https://crrev.com/f660c935c53b2b22d0ef70f74c28106282fcb25c Cr-Commit-Position: refs/heads/master@{#297318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/ui/android/context_menu_helper.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
David Trainor- moved to gerrit
ptal thanks!
6 years, 2 months ago (2014-09-29 23:01:56 UTC) #2
Yaron
lgtm
6 years, 2 months ago (2014-09-29 23:05:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/610913004/1
6 years, 2 months ago (2014-09-29 23:39:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2e98c957171ee9f46d09cfd401a0ac7e9697b14d
6 years, 2 months ago (2014-09-30 00:44:40 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 00:45:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f660c935c53b2b22d0ef70f74c28106282fcb25c
Cr-Commit-Position: refs/heads/master@{#297318}

Powered by Google App Engine
This is Rietveld 408576698